FirebaseUI-Flutter icon indicating copy to clipboard operation
FirebaseUI-Flutter copied to clipboard

feat(ui_firestore): Expose index to FirestoreItemBuilder

Open jt274 opened this issue 6 months ago • 15 comments

Description

This PR exposes the itemBuilder index in FirestoreListView and FirestoreListView.separated to be consistent with flutter's ListView.builder and ListView.separated. There are situations where an index is required, such as when numbering the list of items in the list view.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • [X] I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • [X] My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • [X] All existing and new tests are passing.
  • [X] I updated/added relevant documentation (doc comments with ///).
  • [X] The analyzer (melos run analyze) does not report any problems on my PR.
  • [X] All unit tests pass (melos run test:unit:all doesn't fail).
  • [X] I read and followed the Flutter Style Guide.
  • [X] I signed the CLA.
  • [X] I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • [X] Yes, this is a breaking change.
  • [ ] No, this is not a breaking change.

jt274 avatar Apr 30 '25 17:04 jt274

Hello 👋, this PR has been opened for more than 2 months with no activity on it.

If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing!

You have 15 days until this gets closed automatically

github-actions[bot] avatar May 28 '25 18:05 github-actions[bot]

@russellwheatley Fix still valid.

jt274 avatar May 28 '25 22:05 jt274

Hello 👋, this PR has been opened for more than 2 months with no activity on it.

If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing!

You have 15 days until this gets closed automatically

github-actions[bot] avatar Jun 25 '25 22:06 github-actions[bot]

@russellwheatley can this be merged?

jt274 avatar Jun 26 '25 11:06 jt274

@jt274 - it seems fair enough to me. I've merged with latest main branch and reran the workflow

russellwheatley avatar Jun 30 '25 10:06 russellwheatley

Hello 👋, this PR has been opened for more than 2 months with no activity on it.

If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing!

You have 15 days until this gets closed automatically

github-actions[bot] avatar Jul 28 '25 10:07 github-actions[bot]

Hello 👋, this PR has been opened for more than 2 months with no activity on it.

If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing!

You have 15 days until this gets closed automatically

github-actions[bot] avatar Aug 25 '25 15:08 github-actions[bot]

@russellwheatley I'm not sure if this is completed yet, as it didn't appear to make it into the last pub release after you merged.

jt274 avatar Aug 26 '25 14:08 jt274

Hello 👋, this PR has been opened for more than 2 months with no activity on it.

If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing!

You have 15 days until this gets closed automatically

github-actions[bot] avatar Sep 23 '25 14:09 github-actions[bot]

@russellwheatley apparently was merged, but does not seem to be released yet.

jt274 avatar Sep 23 '25 14:09 jt274

Hello 👋, this PR has been opened for more than 2 months with no activity on it.

If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing!

You have 15 days until this gets closed automatically

github-actions[bot] avatar Oct 21 '25 15:10 github-actions[bot]

@russellwheatley Still not released?

jt274 avatar Oct 23 '25 13:10 jt274

Hey @jt274 - you need to either update this PR or create a new one. It wasn't merged with main, I just ran the CI. You need to completely remove anything not related to the exposing the index to FirestoreItemBuilder

russellwheatley avatar Nov 11 '25 11:11 russellwheatley

@jt274 @russellwheatley, can this task be done already, please!

Hassico avatar Nov 18 '25 18:11 Hassico

@russellwheatley branch should be fixed!

jt274 avatar Nov 18 '25 22:11 jt274