FirebaseUI-Flutter icon indicating copy to clipboard operation
FirebaseUI-Flutter copied to clipboard

fix(firebase_ui_auth): Avoid redundant confirmation on account deletion

Open EArminjon opened this issue 7 months ago • 2 comments

Description

When user try to delete his account, when the exception 'requires-recent-login' appear, user need to login again and click again on the modal to confirm the account deletion. That's redundant.

Related Issues

This PR can also bring some beneficts to this PR : https://github.com/firebase/FirebaseUI-Flutter/pull/493, if developer override the deletion modal to provide one (for example) using a TextController to ensure that user well want to delete his account (no miss click), the recall of the confirmation will present twice a TextController to fill.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • [X] I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • [X] My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • [X] All existing and new tests are passing.
  • [X] I updated/added relevant documentation (doc comments with ///).
  • [X] The analyzer (melos run analyze) does not report any problems on my PR.
  • [X] All unit tests pass (melos run test:unit:all doesn't fail).
  • [X] I read and followed the Flutter Style Guide.
  • [X] I signed the CLA.
  • [X] I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • [ ] Yes, this is a breaking change.
  • [X] No, this is not a breaking change.

EArminjon avatar Apr 16 '25 14:04 EArminjon

Hello 👋, this PR has been opened for more than 2 months with no activity on it.

If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing!

You have 15 days until this gets closed automatically

github-actions[bot] avatar May 14 '25 20:05 github-actions[bot]

Get ou bot

EArminjon avatar May 14 '25 20:05 EArminjon

Hello 👋, this PR has been opened for more than 2 months with no activity on it.

If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing!

You have 15 days until this gets closed automatically

github-actions[bot] avatar Jun 11 '25 21:06 github-actions[bot]

Get out bot

@russellwheatley please take a look :)

EArminjon avatar Jun 11 '25 21:06 EArminjon

Hello 👋, this PR has been opened for more than 2 months with no activity on it.

If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing!

You have 15 days until this gets closed automatically

github-actions[bot] avatar Jul 12 '25 06:07 github-actions[bot]

Get away bot

EArminjon avatar Jul 12 '25 06:07 EArminjon

Ty a lot

EArminjon avatar Jul 28 '25 13:07 EArminjon