FirebaseUI-Flutter icon indicating copy to clipboard operation
FirebaseUI-Flutter copied to clipboard

fix(firebase_ui_auth): Catch sms code validation

Open wer-mathurin opened this issue 8 months ago • 5 comments

Description

This allow the user to pass an onError function when an error happen when validating the sms code

Related Issues

https://github.com/firebase/FirebaseUI-Flutter/issues/481

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • [x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • [ ] My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • [x] All existing and new tests are passing.
  • [x] I updated/added relevant documentation (doc comments with ///).
  • [X] The analyzer (melos run analyze) does not report any problems on my PR.
  • [x] All unit tests pass (melos run test:unit:all doesn't fail).
  • [x] I read and followed the Flutter Style Guide.
  • [x] I signed the CLA.
  • [x] I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • [x] Yes, this is a breaking change.
  • [ ] No, this is not a breaking change.

wer-mathurin avatar Mar 14 '25 19:03 wer-mathurin

@russellwheatley just a working example of what need to be accomplish.

But the way I've done it may need refactoring. Affecting a completer more than once does not smell well... Since I'm not familiar with this package, Who can help me with this?

This is a breaking change since the Completer must return a nullable value.

wer-mathurin avatar Mar 14 '25 19:03 wer-mathurin

Hello 👋, this PR has been opened for more than 2 months with no activity on it.

If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing!

You have 15 days until this gets closed automatically

github-actions[bot] avatar Apr 11 '25 20:04 github-actions[bot]

@russellwheatley: Just ping to make sure this is not automagically close

wer-mathurin avatar Apr 23 '25 15:04 wer-mathurin

Hello 👋, this PR has been opened for more than 2 months with no activity on it.

If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing!

You have 15 days until this gets closed automatically

github-actions[bot] avatar May 21 '25 16:05 github-actions[bot]

Hello 👋, this PR has been opened for more than 2 months with no activity on it.

If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing!

You have 15 days until this gets closed automatically

github-actions[bot] avatar Jun 19 '25 07:06 github-actions[bot]