FirebaseUI-Android icon indicating copy to clipboard operation
FirebaseUI-Android copied to clipboard

[Internal] Kill our custom baseline textview

Open SUPERCILEX opened this issue 7 years ago • 7 comments

This went through: https://github.com/material-components/material-components-android/pull/56

Should be done when we upgrade to support lib v28 after v4.2.1.

SUPERCILEX avatar Sep 27 '18 03:09 SUPERCILEX

Here's the class: https://github.com/firebase/FirebaseUI-Android/blob/8bda799672d44fd2994d2498441859fae3ccb530/auth/src/main/java/com/firebase/ui/auth/util/ui/BaselineTextInputLayout.java

SUPERCILEX avatar Sep 27 '18 03:09 SUPERCILEX

@SUPERCILEX you're everywhere! SGTM

samtstern avatar Sep 27 '18 17:09 samtstern

Upgrading to compile SDK 28 gave me some weird build issues, so will deal with this in 4.3.0 (which will come soon after 4.2.1).

samtstern avatar Oct 23 '18 13:10 samtstern

This has been released in version 4.3.0.

samtstern avatar Dec 13 '18 22:12 samtstern

Looking at TextInputLayout.class in the 28.0.0 release of the design support library, I don't think your change made it in :-/

samtstern avatar Jan 02 '19 18:01 samtstern

Huh, I guess it's only available in AndroidX. Maybe it's time to do the migration?

SUPERCILEX avatar Jan 02 '19 20:01 SUPERCILEX

Yeah one of many reasons! I guess we have to just swallow that pill soon.

samtstern avatar Jan 02 '19 20:01 samtstern