rtcstats-server icon indicating copy to clipboard operation
rtcstats-server copied to clipboard

fileFormat 2 breaks time series in webrtc-dump-importer

Open johnryan opened this issue 5 years ago • 2 comments

It looks like the fileFormat 2 causes the time series to render incorrectly:

This is rendered with the fileFormat v2: Screen Shot 2019-08-12 at 10 47 44 PM

If I remove the "fileFormat":2 in the extracted file it seems to render correctly: Screen Shot 2019-08-12 at 10 47 33 PM

Is this a known issue / expected behavior / user error?

Thanks!

johnryan avatar Aug 13 '19 05:08 johnryan

works for me. The graph looks as if stats[id].timestamp is undefined in https://github.com/fippo/webrtc-dump-importer/blob/gh-pages/rtcstats.html#L357 - which could happen if you use a v1 js with a server that assumes v2

fippo avatar Aug 13 '19 17:08 fippo

@fippo Interesting, should the server be checking the client version before writing the fileFormat: 2 parameter? Interestingly I also saw this behavior with the output from running npm run test is the seed data for that still in the legacy format?

johnryan avatar Aug 13 '19 17:08 johnryan