waltz icon indicating copy to clipboard operation
waltz copied to clipboard

Use value from named-settings.js in settingsService call

Open TL41 opened this issue 1 year ago • 0 comments

Description

Current setup exports authentication: "web.authentication" but doesn't use it

We should change the alias to something like webAuthentication and then use it in the code; this better aligns with the approach used throughout and is a little easier to find.

https://github.com/search?q=repo%3Afinos%2Fwaltz%20findordefault(%22&type=code There are two other cases like this - quick updates to clean things up


waltz-ng/client/system/named-settings.js

    authentication: "web.authentication",

but this was implemented in waltz-ng/client/navbar/directives/navbar-profile.js

        .findOrDefault("web.authentication", "")
        .then(webAuthentication => {
            vm.allowDirectLogin = webAuthentication === "waltz";
        });


### Resourcing

We would like to add this request to the Waltz team's task backlog

TL41 avatar Dec 17 '23 03:12 TL41