Attestations: changes to data types for logical flows not picked up as 'breaking' changes to app flow attestation

[davidwatkins73]

Description

Looks like data type changes to logical flow are incorrectly recorded with a child_kind of DATA_TYPE not LOGICAL_DATA_FLOW.

Historical fix To fix old data use something like:

update change_log
set child_kind = 'LOGICAL_DATA_FLOW'
where child_kind = 'DATA_TYPE' and parent_kind = 'APPLICATION' and message like 'Logical Flow % Data types changed %';

Waltz Version

1.39

[davidwatkins73]

This approach may not work as it would put the burden of attestation on both source and target apps as we could not distinguish which log messages are for which apps.

Perhaps we need to add a new column to change_log: needs_attestation (boolean).

[davidwatkins73]

Problematic code is here: org.finos.waltz.service.data_type.DataTypeDecoratorService#audit