waltz icon indicating copy to clipboard operation
waltz copied to clipboard

Published 20 hours ago • verified publisher icon finos

Data Extractors: support queries without dialect

Open davidwatkins73 opened this issue 5 years ago • 1 comments

Fix for #4288 involved ensuring the passed qry had been generated via a dsl instance, not the DSL class.

I think we can do a dsl.fetch(qry) in the BaseExtractor class (getting the fields from result.fields()) and avoid this type of error in future.

davidwatkins73 avatar Aug 16 '19 13:08 davidwatkins73

This will have been slightly impacted by #4597. The BaseExtractor has now been renamed DirectDataBasedExtractor.

davidwatkins73 avatar Jan 23 '20 16:01 davidwatkins73