vuu icon indicating copy to clipboard operation
vuu copied to clipboard

Typeahead not working with `JoinTable`

Open junaidzm13 opened this issue 1 year ago • 1 comments

Bug Report

Steps to Reproduce:

  • Create a join table in our demo app (e.g. SIMUL Instrument Prices)
  • Try adding an = filter on a string column (e.g. ric)
  • You'd notice that the typeahead is not working, you can see the error in your browser console

Expected Result:

Typeahead should work as for any other not joined in-memory table.

Actual Result:

It throws an exception on the Vuu server when creating the InMemColumnValueProvider. There we check if the passed table is of type InMemDataTable, if it is then we go ahead and create it otherwise we throw an exception.

But on the server side JoinTable extends DataTable directly, which means JoinTable is not of type InMemDataTable (not sure what's the context behind this) and hence, the exception.

Additional Context:

JoinTable: https://github.com/finos/vuu/blob/71700fde0dc2431ebf98022f04753e14940c3a67/vuu/src/main/scala/org/finos/vuu/core/table/JoinTable.scala#L660 InMemColumnValueProvider: https://github.com/finos/vuu/blob/11b94a05c20b576f179cc4f15dbe2bb099406e66/vuu/src/main/scala/org/finos/vuu/core/table/ColumnValueProvider.scala#L24-L29

junaidzm13 avatar May 22 '24 03:05 junaidzm13

Will work on this and discuss with @naleeha about it when she's free.

wendymiaoo avatar Jun 25 '24 13:06 wendymiaoo

https://github.com/finos/vuu/pull/1632

tanjjj avatar Jul 28 '25 10:07 tanjjj