finos
Build arm64/aarch64 Linux wheels
Add aarch64 Linux wheel to the build, and include it in the release artifacts.
Combined effort with @Oblynx from #3093.
Also:
- Add a simple DCO check to the pre-push hook. This is not quite 100% foolproof, as it only checks HEAD, but can fix in a follow up.
- Fix an issue in the build script where we were both building protoc from source and also downloading binaries to be installed.
- Add some
df -hinvocations to the Python job to monitor disk free space.
Public note to self: I think maybe the action we use to install cmake is installing an x86-64 build of cmake on the arm runner. Will pick up on this thread next.
It appears the setup_cmake action doesn't yet support arm64/aarch64.
See:
- https://github.com/jwlawson/actions-setup-cmake/blob/v2/src/version.ts#L59-L73
- https://github.com/jwlawson/actions-setup-cmake/issues/79
I'll fork, use the fork here to test it, then submit a PR to the action upstream.
Pointed it to my fork of the cmake action. PR to upstream https://github.com/jwlawson/actions-setup-cmake/pull/83
Hey @tomjakubowski thanks for working on this! I don't know if you were influenced by my issue #3091 ?
I ran into the same problems as you and propose solutions in #3093.
@Oblynx continuing discussion from your related PR: https://github.com/perspective-dev/perspective/pull/3093
Thanks again for your work! I've cherry-pick your commits onto my branch and fixed up a couple remaining items to get this ready to ship. It looks like correcting the unnecessary downloading of the protoc binary, which we discussed on your PR, is actually enough to fix the disk space issues in the Python builds for now. I've also added some df commands to the job so that we can keep an eye on disk usage going forward.
Don't add comments asking when a feature will be delivered or a reported issue fixed.
