perspective icon indicating copy to clipboard operation
perspective copied to clipboard

Add directory in repository definition for all (generated) package.json files

Open tsteenbe opened this issue 3 years ago • 1 comments

Adding directory will enable perspective users to use to license/security compliance tool such ORT to verify included FOSS licenses, generated SBOMs and create a source code bundle.

packages/perspective-cli/package.json#L18-L21

    "repository": {
        "type": "git",
        "url": "https://github.com/finos/perspective"
    },

NPN package-json#repository says "If the package.json for your package is not in the root directory (for example if it is part of a monorepo), you can specify the directory in which it lives"

    "repository": {
        "type": "git",
        "url": "https://github.com/finos/perspective"
        "directory": "packages/perspective-cli"
    },

Similarly rust/perspective-viewer/package.json should be

    "repository": {
        "type": "git",
        "url": "https://github.com/finos/perspective"
        "directory": "rust/perspective-viewer"
    },

tsteenbe avatar Nov 28 '22 17:11 tsteenbe

Normally I would submit a PR to fix up the package.json but it seems several of these are generated, not sure by what.

tsteenbe avatar Nov 28 '22 17:11 tsteenbe