morphir-elm icon indicating copy to clipboard operation
morphir-elm copied to clipboard

morphir Char sdk includes toLocaleUpper and toLocaleLower

Open edwardpeters opened this issue 11 months ago • 0 comments

Describe the bug The morphir SDK for Char includes a pair of functions toLocaleUpper and toLocalLower. These appear to rely on system-dependent settings, and are not appropriate for the pure functional nature of Morphir. They appear to have been copied from elm-core.

These functions should either be removed, or modified to take the Locale as a parameter. References to them may be found in https://github.com/finos/morphir-elm/blob/main/src/Morphir/IR/SDK/Char.elm and few other morphir-elm files.

edwardpeters avatar Mar 21 '24 15:03 edwardpeters