legend icon indicating copy to clipboard operation
legend copied to clipboard

Adds Juju release publish github action

Open claudiubelu opened this issue 3 years ago • 7 comments

This action will be triggered whenever a change is detected in the releases/ folder.

If there is a new release that was not yet published on charmhub, it will upload the respective FINOS Legend Engine, SDLC, and Studio images into charmhub and make a release. It will also create a new release on latest.

claudiubelu avatar Mar 28 '22 09:03 claudiubelu

Thank you for your contribution and Welcome to our Open Source Community!

To make sure your pull request is accepted successfully, we ask all our open source contributors to sign a Contributor License Agreement; having reviewed our contributor list, we require a CLA for the following people : (@claudiubelu).

In order to sign a CLA with FINOS, just submit a Pull Request with a simple change to this file (adding an empty line, or some random text at the bottom); this will trigger the EasyCLA bot, which will post a comment to the Pull Request stating whether all PR contributors are covered by FINOS CLA; if not covered, the bot will post instructions on how to sign the CLA.

Thanks once again for your contribution. Let us work with you to make the CLA process quick, easy and efficient so we can move forward with reviewing and accepting your pull request. Feel free to email [email protected] for any questions.

cc @maoo @TheJuanAndOnly99 @mcleo-d

finos-cla-bot[bot] avatar Mar 28 '22 09:03 finos-cla-bot[bot]

FYI - just added CHARMCRAFT_AUTH secret, so that the action can run smoothly.

Will work now on CLA Bot configuration to validate PR.

@epsstan @beekemarie @agitana - could could please review this PR? We'd like to merge it as soon as possible, preferably today. TY!

NOTE! This actions will manage only future releases, not existing ones.

maoo avatar Mar 28 '22 09:03 maoo

@cla-bot[bot] check

maoo avatar Mar 28 '22 11:03 maoo

The cla-bot has been summoned, and re-checked this pull request!

finos-cla-bot[bot] avatar Mar 28 '22 11:03 finos-cla-bot[bot]

Hey @maoo

I believe a better place for this action to live in would be the legend config repo https://github.com/finos/legend-config

You can change the trigger mechanism to be workflow_dispatch and schedule with a once a day cron - this should be more than enough considering the frequency of new releases.

Obviously this would also involve having to check out the finos/legend repo as part of the action, to get access to the latest manifest.json, since the action would now run under finos/legend-config

ivan-kyosev-gs avatar Mar 31 '22 16:03 ivan-kyosev-gs

Hey @maoo

I believe a better place for this action to live in would be the legend config repo https://github.com/finos/legend-config

You can change the trigger mechanism to be workflow_dispatch and schedule with a once a day cron - this should be more than enough considering the frequency of new releases.

Obviously this would also involve having to check out the finos/legend repo as part of the action, to get access to the latest manifest.json, since the action would now run under finos/legend-config

Hello.

https://github.com/finos/legend-config doesn't seem to exist or to be public, I cannot access it. Because of that, I will not be able to send this PR there. Will keep it here until that changes.

I've changed the trigger mechanism to workflow_dispatch and schedule with once per day cron.

claudiubelu avatar Apr 04 '22 07:04 claudiubelu

@claudiubelu - let's use https://github.com/finos/legend-integration-juju to host this action; if it cannot be close to manifest.json, then I think this repo is the best option we have. Thanks!

maoo avatar Apr 04 '22 08:04 maoo

This PR is stale because it has been open for 30 days with no activity. Please remove stale label or add any comment to keep this open. Otherwise this will be closed in 5 days.

finos-admin avatar Sep 07 '22 02:09 finos-admin

This PR was closed because it has been inactive for 35 days. Please re-open if this PR is still relevant.

finos-admin avatar Sep 12 '22 12:09 finos-admin