legend-studio icon indicating copy to clipboard operation
legend-studio copied to clipboard

add support of text mode for services with only query

Open gs-gunjan opened this issue 2 years ago • 3 comments

Summary

This change allows users to specify a service with only query. This support is only extended to text mode.

How did you test this change?

  • [ ] Test(s) added
  • [x] Manual testing (please provide screenshots/recordings)
  • [ ] No testing (please provide an explanation)

gs-gunjan avatar Oct 18 '22 11:10 gs-gunjan

🦋 Changeset detected

Latest commit: b1e3072cf1c8b75010c7dd8ee2bef1c4f6a037c0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 27 packages
Name Type
@finos/legend-graph Major
@finos/legend-application-studio Minor
@finos/legend-query-builder Patch
@finos/legend-application-pure-ide Patch
@finos/legend-application-query-bootstrap Patch
@finos/legend-application-query Patch
@finos/legend-application-studio-bootstrap Patch
@finos/legend-application-taxonomy-bootstrap Patch
@finos/legend-application-taxonomy Patch
@finos/legend-application Patch
@finos/legend-extension-dsl-data-space Patch
@finos/legend-extension-dsl-diagram Patch
@finos/legend-extension-dsl-mastery Patch
@finos/legend-extension-dsl-persistence-cloud Patch
@finos/legend-extension-dsl-persistence Patch
@finos/legend-extension-dsl-service Patch
@finos/legend-extension-dsl-text Patch
@finos/legend-extension-format-json-schema Patch
@finos/legend-extension-format-morphir Patch
@finos/legend-extension-store-flat-data Patch
@finos/legend-extension-store-relational Patch
@finos/legend-extension-store-service-store Patch
@finos/legend-manual-tests Patch
@finos/legend-application-pure-ide-deployment Patch
@finos/legend-application-query-deployment Patch
@finos/legend-application-studio-deployment Patch
@finos/legend-application-taxonomy-deployment Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Oct 18 '22 11:10 changeset-bot[bot]

Codecov Report

Merging #1570 (b1e3072) into master (17eb4f4) will increase coverage by 0.00%. The diff coverage is 37.17%.

@@           Coverage Diff           @@
##           master    #1570   +/-   ##
=======================================
  Coverage   41.47%   41.47%           
=======================================
  Files        1386     1386           
  Lines       60727    60776   +49     
  Branches    13777    13800   +23     
=======================================
+ Hits        25185    25208   +23     
- Misses      35439    35465   +26     
  Partials      103      103           
Impacted Files Coverage Δ
...editor/edit-panel/service-editor/ServiceEditor.tsx 77.06% <0.00%> (ø)
...it-panel/service-editor/ServiceExecutionEditor.tsx 41.48% <ø> (+0.35%) :arrow_up:
...ializationHelpers/V1_ServiceSerializationHelper.ts 82.24% <ø> (ø)
...r/src/stores/workflows/ServiceQueryBuilderState.ts 12.24% <0.00%> (-0.80%) :arrow_down:
...ment-editor-state/service/ServiceExecutionState.ts 28.52% <12.50%> (-0.98%) :arrow_down:
...nel/service-editor/ServiceExecutionQueryEditor.tsx 46.84% <20.00%> (-0.86%) :arrow_down:
.../service-editor/testable/ServiceTestableEditor.tsx 11.29% <25.00%> (+2.77%) :arrow_up:
...tor-state/service/testable/ServiceTestDataState.ts 12.59% <50.00%> (-0.21%) :arrow_down:
...shared/modifier/DSL_Service_GraphModifierHelper.ts 43.01% <50.00%> (+0.61%) :arrow_up:
...tion/changeDetection/DSL_Service_ObserverHelper.ts 22.93% <50.00%> (+1.44%) :arrow_up:
... and 8 more

codecov[bot] avatar Oct 18 '22 11:10 codecov[bot]

@gs-gunjan I converted it draft, when this is read for review, please flip it back on. Thanks!

akphi avatar Oct 19 '22 14:10 akphi

Screenshot (39) Screenshot (40) Screenshot (38)

gs-gunjan avatar Nov 14 '22 09:11 gs-gunjan

legend engine change: https://github.com/finos/legend-engine/commit/818b0819181fbfe8aaf8924f3fb55b327f58de29

gs-gunjan avatar Nov 15 '22 07:11 gs-gunjan

Screenshot (44)

gs-gunjan avatar Nov 15 '22 12:11 gs-gunjan

@gs-gunjan could we fix the code checks for the build. Also can we rebase (this will clear up the intergration tests that are failing). After that I can merge. I'll address at the other comments I left. Thankis!

MauricioUyaguari avatar Dec 05 '22 14:12 MauricioUyaguari