legend-studio
legend-studio copied to clipboard
feat: add mapper post processor editor
Summary
Fixes #945
Picture and gif of how post processor editor works:
If there are duplicate values of a table mapper or schema mapper, the duplicated mappers will be in red until user changes their properties to not duplicate
- [ ] panelize explore + content
If there is no editor available for post processor, blank panel will appear
How did you test this change?
- [ ] Test(s) added
- [x] Manual testing (please provide screenshots/recordings)
- [ ] No testing (please provide an explanation)
🦋 Changeset detected
Latest commit: 0ef8229a9424edb1b2794e51e7e3034dbc924d1d
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 29 packages
Name | Type |
---|---|
@finos/legend-art | Minor |
@finos/legend-application-studio | Minor |
@finos/legend-graph | Minor |
@finos/legend-shared | Minor |
@finos/legend-application-query-bootstrap | Patch |
@finos/legend-application-query | Patch |
@finos/legend-application-studio-bootstrap | Patch |
@finos/legend-application-taxonomy-bootstrap | Patch |
@finos/legend-application-taxonomy | Patch |
@finos/legend-application | Patch |
@finos/legend-extension-application-studio-management-toolkit | Patch |
@finos/legend-extension-application-studio-query-builder | Patch |
@finos/legend-extension-dsl-data-space | Patch |
@finos/legend-extension-dsl-diagram | Patch |
@finos/legend-extension-dsl-mastery | Patch |
@finos/legend-extension-dsl-persistence | Patch |
@finos/legend-extension-dsl-text | Patch |
@finos/legend-extension-external-language-morphir | Patch |
@finos/legend-extension-external-store-service | Patch |
@finos/legend-manual-tests | Patch |
@finos/legend-extension-dsl-persistence-cloud | Patch |
@finos/legend-extension-external-format-json-schema | Patch |
@finos/legend-extension-tracer-zipkin | Patch |
@finos/legend-server-depot | Patch |
@finos/legend-server-sdlc | Patch |
@finos/legend-storage | Patch |
@finos/legend-application-query-deployment | Patch |
@finos/legend-application-studio-deployment | Patch |
@finos/legend-application-taxonomy-deployment | Patch |
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
Codecov Report
Merging #1434 (0ef8229) into master (ddc2a03) will decrease coverage by
0.11%
. The diff coverage is13.94%
.
@@ Coverage Diff @@
## master #1434 +/- ##
==========================================
- Coverage 40.71% 40.60% -0.12%
==========================================
Files 1225 1230 +5
Lines 53956 54176 +220
Branches 12197 12261 +64
==========================================
+ Hits 21969 21997 +28
- Misses 31910 32102 +192
Partials 77 77
Impacted Files | Coverage Δ | |
---|---|---|
...nts/editor/edit-panel/UnsupportedElementEditor.tsx | 11.11% <ø> (ø) |
|
...mapping-editor/InstanceSetImplementationEditor.tsx | 14.72% <ø> (ø) |
|
...ditor-state/connection/PostProcessorEditorState.ts | 0.00% <0.00%> (ø) |
|
packages/legend-graph/src/graph/Core_HashUtils.ts | 100.00% <ø> (ø) |
|
...tore/relational/connection/postprocessor/Mapper.ts | 0.00% <0.00%> (ø) |
|
...lational/connection/postprocessor/PostProcessor.ts | 0.00% <0.00%> (ø) |
|
.../changeDetection/StoreRelational_ObserverHelper.ts | 12.63% <6.66%> (-0.40%) |
:arrow_down: |
packages/legend-art/src/components/panel/Panel.tsx | 7.14% <7.14%> (ø) |
|
...tion-editor/RelationalDatabaseConnectionEditor.tsx | 25.55% <8.19%> (-3.02%) |
:arrow_down: |
...ost-processor-editor/MapperPostProcessorEditor.tsx | 13.84% <13.84%> (ø) |
|
... and 6 more |
@xannem when we already linked a PR to the issue, let's add the issue to the project instead of adding the PR to the project. Thanks!
Nice work! Just a reminder, we will need to revisit and fix up the padding
in Panel...
component.
@xannem @akphi as part of this to help users specify post processors, could we provide text examples in text mode. For core ones we can provide them directly and for extensions we leverage
getExtraPureGrammarParserElementSnippetSuggestionsGetters