legend-engine icon indicating copy to clipboard operation
legend-engine copied to clipboard

Java Generation: Generate classes for concrete function parameters

Open aziemchawdhary-gs opened this issue 1 year ago • 1 comments

M2M execution relies on source fetch tree computation to generate the list of Pure classes to generate Java code for. However, if a function is passed an empty argument then there is no property access and hence nothing is present in the source tree informing the platform that Java code should be generated for the corresponding parameter type. As a result the compilation of Java code present in the execution plan fails due to missing classes.

This change fixes that by processing the parameters and generating code for parameter types that are not part of the Java standard library or engine conventions library. If we happen to have already generated code for the parameter type earlier in the plan generation (e.g the class is mentioned in the source fetch tree) then the Java generation merging code will handle duplicates that may be generated by this changeset.

aziemchawdhary-gs avatar Apr 16 '24 13:04 aziemchawdhary-gs

Test Results

     763 files  +  2       763 suites  +2   1h 6m 35s :stopwatch: - 1m 46s 12 598 tests +49  12 365 :heavy_check_mark: +49  233 :zzz: ±0  0 :x: ±0  15 709 runs  +49  15 458 :heavy_check_mark: +49  251 :zzz: ±0  0 :x: ±0 

Results for commit 9a8cd944. ± Comparison against base commit d7d0f47d.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Apr 16 '24 15:04 github-actions[bot]