legend-engine icon indicating copy to clipboard operation
legend-engine copied to clipboard

Published 20 hours ago • verified publisher icon finos

More complete support for Pure queries in the Rel transpiler

Open relationalai-opensource opened this issue 1 year ago • 4 comments

Various improvements to the Rel transpiler including:

  • Implements complete support for match functions which are now routed.
  • Implements better tracing logic for debugging when a Pure query is not supported by the Rel transpiler, including pretty printing of the intermediate form.
  • Correct handing of the in operator.
  • Fixes handling of at when used along a property path.
  • Necessary changes to the passing of set implementations because the store contact has been updated to ensure that match functions are routed.
  • Tests have been added and updated to improve test coverage.
  • Generated Rel queries are now pretty printed for easier reading and easier to parse Rel.
  • Refactoring and code cleanup. Removing dead code.

What type of PR is this?

Improvement

What does this PR do / why is it needed ?

Support for more types of query by the Rel backend. This PR also improves the logging of errors when a Pure query is not supported by the Rel transpiler.

Does this PR introduce a user-facing change?

This PR is backwards compatible in the sense that existing queries will continue to be supported without any changes.

relationalai-opensource avatar Feb 10 '24 00:02 relationalai-opensource

Test Results

0 files  ±0  0 suites  ±0   0s :stopwatch: ±0s 0 tests ±0  0 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit 284889b8. ± Comparison against base commit 939caa6c.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Feb 10 '24 02:02 github-actions[bot]

I have merged master into this branch to fix the merge conflict. It says that merging is blocked because the WhiteSource security check has failed, but the vulnerabilities reported are not related to the changes made in this PR.

andrew-bate-rai avatar Mar 13 '24 22:03 andrew-bate-rai

This PR can be closed because it is superseded by PR#2702 which has now been merged.

relationalai-opensource avatar Apr 10 '24 16:04 relationalai-opensource

This PR can be closed because it is superseded by https://github.com/finos/legend-engine/pull/2702. Apologies for the noise.

andrew-bate-rai avatar Apr 11 '24 16:04 andrew-bate-rai

This PR is stale because it has been open for 30 days with no activity. Please remove stale label or add any comment to keep this open. Otherwise this will be closed in 5 days.

finos-admin avatar May 12 '24 12:05 finos-admin

This PR was closed because it has been inactive for 35 days. Please re-open if this PR is still relevant.

finos-admin avatar May 17 '24 12:05 finos-admin