compliant-financial-infrastructure
compliant-financial-infrastructure copied to clipboard
finos
Modify Openshift SAA to follow new template
Feature Request
The SAA template has been updated per issue #223 in PR #225. As such, we need to update the Openshift SAA to follow the new simplified template.
Hi @eddie-knight - just wanted to check something on the template changes that came as a result of issue #223 - did the changes to the SAA template in PR #224 get applied as its not clear to me where to get the updated template from as this looks like the old template. Thanks A
@abdullahgarcia @thinkl33t Can we go ahead and merge PR #224? I think that will resolve @AdrianHammond's question here and let the team move forward with this issue
Yeah there's one more typofix in there, once thats done we can merge :) @thinkl33t
Oh dang. I'm not seeing any more comments on there... what am I overlooking?
Let's move things forward.
@AdrianHammond , the PR has been merged. Let us know if there are any questions.
Yeah there's one more typofix in there, once thats done we can merge :) @thinkl33t
Oh dang. I'm not seeing any more comments on there... what am I overlooking?
Apparently the review was still 'pending' and i couldn't finalize it from github mobile :facepalm:
Gents - Thanks for progressing PR #224. Please could we get this issue reopened as I still need to do the work to update the OCP Service Accelerator.
Apparently the review was still 'pending' and i couldn't finalize it from github mobile :facepalm:
GitHub mobile is kicking my butt today as well. I went to quote Adrian's comment and ended up editing it by mistake.
@AdrianHammond ...Sorry for the miscommunication here, and thanks for helping move the OCP work forward!
Apparently the review was still 'pending' and i couldn't finalize it from github mobile 🤦
GitHub mobile is kicking my butt today as well. I went to quote Adrian's comment and ended up editing it by mistake.
@AdrianHammond ...Sorry for the miscommunication here, and thanks for helping move the OCP work forward!
no worries @eddie-knight
Hi @AdrianHammond 👋🏻
Are you happy to drive this issue update during #256 given the conversation with @eddie-knight and @abdullahgarcia ?
Cheers 🍻
James.
Work started in this fork https://github.com/johanalimka/compliant-financial-infrastructure/tree/ocp_411
In this issue we will complete following:
- [ ] Update documentation to reflect release of Red Hat OpenShift 4.11
- [x] Update the service accelerator to reflect PR #224
Hi @AdrianHammond - It would be great to get an update on this issue during #265 if possible?
Making good progress, hope to open PR in next week or so. Review with @peter-thomas-db arranged for 10/11.
#291 opened for this issue. @eddie-knight @thinkl33t @abdullahgarcia - please someone review / approved. I discussed what Johana and I were doing with @peter-thomas-db a few weeks ago but didn't take him through the detail. Major change is using new SAA template.