common-domain-model icon indicating copy to clipboard operation
common-domain-model copied to clipboard

JEAN BAPTISTE ZIADE MatrixTermEnum and ContractualSupplementTypeEnum - see GitHub Issue 3186

Open regnosys-prod-user opened this issue 3 months ago • 6 comments

regnosys-prod-user avatar Aug 25 '25 09:08 regnosys-prod-user

MatrixTermEnum and ContractualSupplementTypeEnum - see GitHub Issue 3186

Background

PROBLEM STATEMENT : the list of of 2021 Definition ancillary documents is currently missing in CDM

What is being released?

  • ancillary documents from the list, which name ends with suffix "Matrix" shall be added as new Enum values in existing type MatrixTermEnum
  • other ones shall be added as new Enum values in existing type ContractualSupplementTypeEnum
  • besides, at higher level there is an existing component for specifying the "asset class" to which ancillary document may relate, that is type MatrixTypeEnum and for now it is missing "rate class", hence need to ContractualMatrix - hence adding new Enum value InterestRateDerivativesMatrix to type MatrixTypeEnum
  • we also found that one of these item was actually already present in CDM which results in overlaps for this specific one, so we need to remove it ; the one to remove is the Enum value SettlementMatrix from MatrixTermEnum (corresponds to new Enum value "2021 ISDA Interest Derivatives Definitions Settlement Matrix" that will be added in MatrixTermEnum per first point)
  • adding publicationDate that is currently missing as new optional attribute for ContractualMatrix`

Review Directions

Changes can be reviewed in PR: #3986

[!NOTE] This comment was generated via Rosetta.

regnosys-prod-user avatar Aug 25 '25 09:08 regnosys-prod-user

Deploy Preview for finos-cdm ready!

Name Link
Latest commit 648746edf564a1f0d7e58866bb2bef902c599b87
Latest deploy log https://app.netlify.com/projects/finos-cdm/deploys/68ac29072c9c730008df392c
Deploy Preview https://deploy-preview-3986--finos-cdm.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

netlify[bot] avatar Aug 25 '25 09:08 netlify[bot]

@llynhiavu please review, as agreed in related issue : https://github.com/finos/common-domain-model/issues/3186

JBZ-Fragmos avatar Aug 25 '25 09:08 JBZ-Fragmos

@finos/cdm-maintainers

please review this PR for release

JBZ-Fragmos avatar Sep 09 '25 13:09 JBZ-Fragmos

@finos/cdm-maintainers @llynhiavu

please review this PR for release - it has been ageing 3 weeks

thanks

jb

JBZ-Fragmos avatar Oct 01 '25 10:10 JBZ-Fragmos

@finos/cdm-maintainers @llynhiavu @lolabeis @dshoneisda

please review this PR for release - it has been ageing for several weeks

thanks

jb

JBZ-Fragmos avatar Oct 14 '25 11:10 JBZ-Fragmos