common-domain-model
common-domain-model copied to clipboard
ValuationDate type and attributes not properly defined
type ValuationDate has multiple issues:
- Attribute singleValuationDate and multipleValuationDates are not a date at all and do not have any date attributes. They actually hold actually an int attribute to define a number of business days.
- fxFixingDate and fxFixingSchedule should not be defined as fx only.
- Since ValuationDate is not a date but a set of attributes to define or adjust a value date it should be called something like ValuationDateSpecification