common-cloud-controls icon indicating copy to clipboard operation
common-cloud-controls copied to clipboard

Contribution Request : OSCAL example that points to MITRE and describes tests using Gherkin

Open mcleo-d opened this issue 2 years ago • 10 comments

Description

During #5 the following requests were raised by the CCC MITRE working group.

  • [ ] Can Citi contribute an existing OSCAL example that can be used as a reference by the MITRE working group?

    • This example could be used to inform further MITRE contributions through OSCAL.
    • Can this contribution be raised as a PR into the CCC repo?
  • [ ] The work related to Storage ( object storage ) [AWS S3, gcp storage, azure object storage] is complete and ready to be contributed into the FINOS CCC repo

    • https://github.com/finos/common-cloud-controls/issues/11#issuecomment-1729746032

--- Update ---

The following item has been moved into its own separate issue as it creates a larger scope.

  • Gherkin should be used as a Behaviour Test rather than a Configuration Test.
    • Can an example of this type of test be expanded upon during a relevant future call?

mcleo-d avatar Aug 31 '23 14:08 mcleo-d

Example that was worked through with @git-hub-forwork1 and MITRE team on #24

Storage ( object storage ) [AWS S3, gcp storage, azure object storage]

Encryption

  • Support for native encryption (platform KMS/HSM)
  • Algo supported
  • FIPS-140 compliance for module
  • In-transit at rest
  • TLS-MA

RBAC

  • Service Specific policy
  • IAM policy
  • Other special policy (CORS, etc..)
  • Network scope restriction
  • Data perimeter

Network boundaries

  • How do I restrict service to specific implementation (expected network) ( VPC, account, etc…)

IAM boundaries PAM Activity Logging

mcleo-d avatar Sep 21 '23 14:09 mcleo-d

confirming with legal that we can contribute, will report back

jonmuk avatar Oct 01 '23 14:10 jonmuk

The following is work done by @smendis-scottlogic in the Taxonomy working group to provide @eddie-knight with Common Features in RDS across AWS, Azure & GCP.

  • https://github.com/finos/common-cloud-controls/pull/39#discussion_r1356880413

Common Features in RDS across AWS, Azure & GCP by @smendis-scottlogic

  1. Supports SQL queries.
  2. Options for vertical scaling (Increase/Decrease size of the database)
  3. Read replicas to improve scalability.
  4. Geo-replication for high availability and fault tolerance
  5. Capability for deploying databases in multiple regions.
  6. Automated backup options
  7. Point-in-time recovery options.
  8. Data encryption at rest
  9. Data encryption in transit
  10. Identity based access control.
  11. Logging capabilities.
  12. Ability to monitor/alert base on metrics.

mcleo-d avatar Oct 19 '23 11:10 mcleo-d

Not sure of the best way to collaborate on this but a brief set of examples below, with some gherkin for discussion around whether this contains the right content. cc @smendis-scottlogic @eddie-knight

Happy to take guidance as to how to continue, the level of depth needed and the correct use of gherkin syntax.

Common Features in RDS across AWS, Azure & GCP by @smendis-scottlogic

  1. Supports SQL queries.

Scenario: T1190 Exploit Public Facing application ~~Scenario: T1059 Command and Scripting Interpreter~~ Given: SQL query access to an RDS instance When: An attacker is able to input data that features a meta character And: Can craft the injection of a SQL Query Then: SQL injection attack is successful And: the confidentiality, integrity, availability of the database is affected.

Scenario: T1078 Valid Accounts Given: An RDS Instance And: Authentication credentials And: SQL Query Interface When: Authentication Credential is compromised Then: Attacker gains unauthorised access to the RDS Instance

  1. Options for vertical scaling (Increase/Decrease size of the database)
  2. Read replicas to improve scalability.
  3. Geo-replication for high availability and fault tolerance
  4. Capability for deploying databases in multiple regions.
  5. Automated backup options

Scenario: T1567.002 Exfiltration Over Web Service: Exfiltration to Cloud Storage Given: An RDS Instance And: An RDS administrator Role When: An on Demand Backup/Snapshot is requested by the administrator And: The backup destination is in a cloud storage resource outside of the organisations control And: the request is successful Then: Database data has been exfiltrated from the organisation.

  1. Point-in-time recovery options.

  2. Data encryption at rest

  3. Data encryption in transit

  4. Identity based access control.

  5. Logging capabilities.

  6. Ability to monitor/alert base on metrics.

Will start adding other examples for discussion later

rowan-baker avatar Oct 19 '23 16:10 rowan-baker

I took a stab at the taxonomy specific elements in #72. I'm hoping that's a good place for us to compile some of this discussion now that we're getting into execution mode.

eddie-knight avatar Oct 20 '23 04:10 eddie-knight

@eddie-knight - this look good.

@mark-rushing @moematar @simonzhangbmo @vicenteherrera - what do you think? Are you okay with this and should we merge #72 ?

AdrianHammond avatar Oct 24 '23 07:10 AdrianHammond

It looks great! Think it would be good to run services/database/relational/rdms-taxonomy.feature past the other two working groups <- @jonmuk @git-hub-forwork1

mark-rushing avatar Oct 24 '23 16:10 mark-rushing

@mark-rushing @jonmuk @git-hub-forwork1 - @eddie-knight has resubmitted new PR #82 as original PR closed and could not be reopened. Are you okay if I merge this PR and then we iterate on it? Eddie is presenting in NYC next week and it would be useful to have the initial view of the taxonomy in the repo. Thanks

AdrianHammond avatar Oct 25 '23 14:10 AdrianHammond

In #91 the working group agreed to review pull request https://github.com/finos/common-cloud-controls/pull/89 to close this issue as part of milestone https://github.com/finos/common-cloud-controls/milestone/4

The definition of done to answer is ...

  • Can Citi contribute an existing OSCAL example that can be used as a reference by the MITRE working group?
    • This example could be used to inform further MITRE contributions through OSCAL.
    • Can this contribution be raised as a PR into the CCC repo?

mcleo-d avatar Nov 16 '23 15:11 mcleo-d

Is Gherkin the only contender here? Or are there other options?

rgriffiths-scottlogic avatar Dec 21 '23 15:12 rgriffiths-scottlogic

This issue will be closed as stale in 7 days. Please update this issue if it is still needed.

github-actions[bot] avatar Jul 10 '24 22:07 github-actions[bot]

Closed as stale. An update may reopen this issue.

github-actions[bot] avatar Jul 17 '24 22:07 github-actions[bot]