a11y-theme-builder icon indicating copy to clipboard operation
a11y-theme-builder copied to clipboard

This PR is to resolve : [EPIC] Allow users to be able to edit palette and default color theme in existing design system #820

Open omesh-omg opened this issue 1 year ago • 4 comments
trafficstars

Adding three pages /steps.

  1. Core Settings
  2. Build Color Palette
  3. Light and Dark Mode

Resolves issue: #820 #914 #916 #917 #918 #919 #920

omesh-omg avatar Jul 25 '24 16:07 omesh-omg

Hey @omesh-omg, sorry that it took me so long to get back to you. So to fix the ESLint errors, you could just add another * in the copyright header (to match the headers in the other legacy files...which I updated with the ESLint changes). But since you are adding new files, you should really give them the new SPDX header like you did for the other PR that you did that added a new file. You really shouldn't add a copyright header saying that Discover created the file when you did :-)

So for your new files, you should use:

/**
 * SPDX-License-Identifier: Apache-2.0
 * Copyright 2024 FINOS A11y Theme Builder contributors - see NOTICE file
 */

I'm currently experiencing an issue running Theme Builder on my machine so I can't run and test your latest code. I'll let you know when I have it resolved. I'll try to at least code review the code tomorrow.

aaronreed708 avatar Aug 01 '24 04:08 aaronreed708

Yessss, I didn't ask for it because I just switched my os to Linux I thought may be there is some issue with my OS it is not able to clone properly and I didn't which way to fix manually or changing eslin** file 🙃🙃

omesh-omg avatar Aug 01 '24 04:08 omesh-omg

Deploy Preview for glistening-gecko-6b417a ready!

Name Link
Latest commit befc822c3f14f8b76bbde7ed1b1d9469c6c00dbc
Latest deploy log https://app.netlify.com/projects/glistening-gecko-6b417a/deploys/687d1037fdd9920008b1f529
Deploy Preview https://deploy-preview-972--glistening-gecko-6b417a.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

netlify[bot] avatar Aug 21 '24 04:08 netlify[bot]

Deploy Preview for dapper-ganache-45a60b ready!

Name Link
Latest commit befc822c3f14f8b76bbde7ed1b1d9469c6c00dbc
Latest deploy log https://app.netlify.com/projects/dapper-ganache-45a60b/deploys/687d103639561800082ae8b8
Deploy Preview https://deploy-preview-972--dapper-ganache-45a60b.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

netlify[bot] avatar Aug 21 '24 04:08 netlify[bot]