a11y-theme-builder icon indicating copy to clipboard operation
a11y-theme-builder copied to clipboard

finos/a11y-theme-builder#903:that lists are structured correctly (ul)

Open ShadabImran07 opened this issue 1 year ago • 4 comments
trafficstars

Corrected the changes @aaronreed708 you have asked regarding issue 903

ShadabImran07 avatar Jun 06 '24 20:06 ShadabImran07

Deploy Preview for glistening-gecko-6b417a ready!

Name Link
Latest commit f73016756e5093d74616a67fe45350ac1a6add90
Latest deploy log https://app.netlify.com/sites/glistening-gecko-6b417a/deploys/666218c1e9967e000874e116
Deploy Preview https://deploy-preview-929--glistening-gecko-6b417a.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Jun 06 '24 20:06 netlify[bot]

I have no problem with the code, but it only seems to fix the "div being inside the list" issue. The list still has an accessibility issue according to Accessibility Insights because of the "role=button" that is on the list items. I found something that might help: mui/material-ui#19469 (comment). It might be worth checking out.

how you are producing this error ,i am checking through its gives me no error see this image

ShadabImran07 avatar Jun 07 '24 17:06 ShadabImran07

@ShadabImran07 try this:

  1. Load a design system
  2. Select Molecules from the tabs at the top
  3. Run the Accessibility Insights

The menu items in the left nav bar under "General Desktop" (like Avatar, Buttons, Cards) seem to be buttons that have the role="button" attribute. Let me know if that doesn't show errors in Accessibility Insights. Thanks!

aaronreed708 avatar Jun 10 '24 13:06 aaronreed708

@aaronreed708 ya i can see that ,I have tried only in hompage that why its not showing the error. i have to check all the sidebar to resolve all the same issue

ShadabImran07 avatar Jun 10 '24 19:06 ShadabImran07