a11y-theme-builder icon indicating copy to clipboard operation
a11y-theme-builder copied to clipboard

adding-normalize.css issue #889

Open omesh-omg opened this issue 1 year ago • 5 comments
trafficstars

this PR resolves issue https://github.com/finos/a11y-theme-builder/issues/868 Adding normalize.css inorder to have consistency across browsers

omesh-omg avatar May 20 '24 18:05 omesh-omg

Deploy Preview for glistening-gecko-6b417a ready!

Name Link
Latest commit 27882a76a0fad4c7afd13cc8e4fd4090a50453fc
Latest deploy log https://app.netlify.com/sites/glistening-gecko-6b417a/deploys/664b921acbfaa60009af28b3
Deploy Preview https://deploy-preview-895--glistening-gecko-6b417a.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar May 20 '24 18:05 netlify[bot]

Is this change ready to try? I tried the Deploy Preview on Netlify above and I don't see a change in behavior here. I still see the 3rd row below the bottom of the browser window.

Also, please ensure that the new .css file doesn't change/break any CSS that Theme Builder adds to the app.

aaronreed708 avatar May 21 '24 21:05 aaronreed708

No I wanted to check preview in safari rest I will have to go through again

omesh-omg avatar May 22 '24 02:05 omesh-omg

I'm not able to detect any MAJOR changes as applied. Can you confirm it once again?

Sweetdevil144 avatar May 22 '24 05:05 Sweetdevil144

Yes, It's difficult to debug without having safari I am going through the material code itself if I can find something. Thanks for helping, meanwhile if you can check it locally btw if there are any changes u can see in primary color drop-down?

omesh-omg avatar May 22 '24 06:05 omesh-omg