768 Add ViewMessages Intent & SearchCriteria Context

[symphony-jean-michael]

This PR adds the 'ViewMessages' intent. See initial discussion https://github.com/finos/FDC3/issues/768

[netlify[bot]]

✅ Deploy Preview for lambent-kulfi-cf51a7 canceled.

Name	Link
🔨 Latest commit	41b3384df0a9f25b2433ad9ec4f820d56c2b91bc
🔍 Latest deploy log	https://app.netlify.com/sites/lambent-kulfi-cf51a7/deploys/636cdb132d5c9200094fd968

[symphony-jean-michael]

Hi @kriswest I updated the PR to take into account your remarks. For the criteria operators, I did what we discussed yesterday, and I updated the description of SearchCriteria to explain that the operators are not defined in the SearchCriteira, but it is up to the application that receives the Intent to choose and apply the operators. (See https://github.com/finos/FDC3/pull/797/files#diff-10b12f0cd7551554329f046508ee812f15561a1ceb30fdd0b99e5e02005a01f6R26 ) Could you have a second look at the PR please? Thanks :)

[kriswest]

Could you have a second look at the PR please?

I haven't yet had a chance for a full review, but as the query fields are restricted so is the use-case. Hence, I still think the type should be scoped for chat. I.e. fdc3.chat.searchCriteria

[symphony-jean-michael]

@kriswest You're right, I renamed fdc3.searchCriteria into fdc3.chat.searchCriteria

[mistryvinay]

Including notes from our last meeting (Sep 2022). With recommended changes for this PR.

• #797
  • Is this a general search criteria, or a specific search criteria for chat? The context specifically limits the criteria and query construction that can be used in a search...
    • Option 1: Make this more flexible to support all search purposes
      • We don't want to define a query for all use-cases at the moment, it would be too large an undertaking
    • Option 2: Refactor it to be chat specific, with a rename to fdc3.chat.searchcriteria
  • Further options for supporting more complex search criteria were discussed
    • E.g. use a Google type search
      • All search clauses are combined with OR
      • Then ranked results are returned based on those OR search criteria values
      • Ranked in order of filter word occurrences
    • Empty search criteria could supported to allow reset of filters (which is a common issue in FDC3 for filters based on context broadcasts)
    • Rename contexts array to criteria to acknowledge that it may contain strings, not just contexts

[symphony-jean-michael]

@mistryvinay FYI:

• "Is this a general search criteria, or a specific search criteria for chat?" The Option 2: has been chosen. It has been renamed to fdc3.chat.searchcriteria Done ✅
• "Further options for supporting more complex search criteria were discussed"
  • "E.g. use a Google type search" There is a paragraph in SearchCriteria.md explaining there are no implementation details in the FDC3 standard. It is up to the application that receives the intent to define how it handles the criteria. Done ✅
  • "Empty search criteria could supported to allow reset of filters (which is a common issue in FDC3 for filters based on context broadcasts)" I've just added a new line about it in the SearchCriteria.md file. Done ✅
  • "Rename contexts array to criteria to acknowledge that it may contain strings, not just contexts" Done ✅

[symphony-jean-michael]

Hi @kriswest I've updated the PR accordingly to your remarks. Can you have a second look, please? Thanks

[symphony-jean-michael]

FYI, this PR is included in new one #882