FDC3
FDC3 copied to clipboard
765 'ChatRoom' & 'ChatMessage' contexts and 'SendChatMessage' Intent
This PR:
- updates the 'StartChat' intent to return a reference to the new created Chat room (ChatRoom)
- supports the possibility to send messages in existing chats (New intent 'SendChatMessage')
See initial discussion https://github.com/finos/FDC3/issues/765
The committers listed above are authorized under a signed CLA.
- :white_check_mark: login: symphony-jean-michael / name: Jean-Michael Legait (df7516962040ba7c352d0c17a41c1bc6a0d9ef3e, 4501ef27293ffb5706a3415d2a8c0f992a937977, d30e3e9b8ac39002b4da18448669fae0d82db84f)
Deploy Preview for lambent-kulfi-cf51a7 ready!
| Name | Link |
|---|---|
| Latest commit | 6a62c406f729d824d265051265c3a196a9d386fc |
| Latest deploy log | https://app.netlify.com/sites/lambent-kulfi-cf51a7/deploys/636cfc4f7ce5550008a05541 |
| Deploy Preview | https://deploy-preview-794--lambent-kulfi-cf51a7.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site settings.
@kriswest I updated the PR taking into account your remarks. Could you have a second look? Thanks
Are we still pending an updated description of use-cases for starting a chat?
- #794
- Deal with review comments and suggestions.
- Consider expanding the description of StartChat to include more details on use-cases for starting a chat from a different application (e.g. a research app or OMS)
Hi @mistryvinay
- "Deal with review comments and suggestions." It seems to me that I've taken into account all the comments and updated the PR accordingly. Could you tell me which comment you're referring to?
- "Consider expanding the description of StartChat to include more details on use-cases for starting a chat from a different application (e.g. a research app or OMS)" Sorry, but I don't really know what to add. You want me to add a message in StartChat explaining why a user would want to start a chat from another application, right? Do you have an idea of a description to add? It would be very helpful for me. 😅
Hi @mistryvinay
- "Deal with review comments and suggestions." It seems to me that I've taken into account all the comments and updated the PR accordingly. Could you tell me which comment you're referring to?
- "Consider expanding the description of StartChat to include more details on use-cases for starting a chat from a different application (e.g. a research app or OMS)" Sorry, but I don't really know what to add. You want me to add a message in StartChat explaining why a user would want to start a chat from another application, right? Do you have an idea of a description to add? It would be very helpful for me. 😅
Currently we have:
# `StartChat`
Initiate a chat with a contact, a list of contacts or detailed initialization settings.
Maybe something along the lines of:
# `StartChat`
Initiate a chat with a contact, a list of contacts or detailed initialization settings. This could be launched from within another application. For example initiating a chat from a research or OMS application.
Hi @mistryvinay Thank you for your feedback. I updated the PR accordingly.
Add a CHANGELOG.md entry in the unreleased section please
Hi @kriswest @mistryvinay I've updated the PR accordingly to your remarks. Can you have a second look, please? Thanks
FYI, this PR is included in new one https://github.com/finos/FDC3/pull/882