FDC3
FDC3 copied to clipboard
766 evolution of chat message data structure
see initial discussion here . let's continue the discussion with a PR, it will make it easier to suggest improvements
The committers listed above are authorized under a signed CLA.
- :white_check_mark: login: ZimmySymphony (56479cc03c9dd094f5ba9b174249e70cf14d70c9)
Deploy Preview for lambent-kulfi-cf51a7 ready!
Name | Link |
---|---|
Latest commit | 7586c45fd97a6f319473ed532b5de45371954f02 |
Latest deploy log | https://app.netlify.com/sites/lambent-kulfi-cf51a7/deploys/637e80968343ed000833f66b |
Deploy Preview | https://deploy-preview-779--lambent-kulfi-cf51a7.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site settings.
first step: the schemas. from what we understand of the pipeline, the types are generated when these are uploaded
to come: the markdown doc
FYI @kriswest we added the "intent" (which is actually an intent name + context) definition to the schemas (previously it was only in a separate yaml), so that we can define an intent as being a possible entity attached to a message.
FYI @kriswest we added the "intent" (which is actually an intent name + context) definition to the schemas (previously it was only in a separate yaml), so that we can define an intent as being a possible entity attached to a message.
The YAML linked describes an Intent definition, although its almost never used as intents are generally just referred to by their name
.
Hence, what you are defining is a context indicating that a particular context and (optional) intent may be used to perform an action at the other end. Hence, I think it important that we differentiate this entity (representing an 'action' that can be taken) from the constituent parts (a context and optional intent). Hence, I am keen that we name this new context 'action' (or something similar)... More on this when I have a moment for deeper review (perhaps at today's meeting).
hey @kriswest I think this one is ready now. Can you have a quick check?
FYI @symphony-jean-michael
Still a few comments to deal with (+ a couple of other things I spotted today) to deal with @mistryvinay @Yannick-Symphony
Add a CHANGELOG.md entry in the unreleased section please
hi @kriswest i've finally had some time to update everything - tell me if it looks OK, and if so either you merge separately or I can start merging the different chat PRs into this one first
FYI, this PR is included in new one https://github.com/finos/FDC3/pull/882