FDC3 icon indicating copy to clipboard operation
FDC3 copied to clipboard

Published 20 hours ago • verified publisher icon finos

592 771 context proposal TransactionResult

Open milindchidrawar opened this issue 2 years ago • 6 comments

Suggested implementation of transaction result as proposed in context data intents working group #742

milindchidrawar avatar Jun 22 '22 14:06 milindchidrawar

Deploy Preview for lambent-kulfi-cf51a7 ready!

Name Link
Latest commit 9d8d14ac9c37a2d751fe67765a79ad1c0c0c785d
Latest deploy log https://app.netlify.com/sites/lambent-kulfi-cf51a7/deploys/637c74ce003348000937e80a
Deploy Preview https://deploy-preview-761--lambent-kulfi-cf51a7.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Jun 22 '22 14:06 netlify[bot]

Hi @milindchidrawar forgot to mention congrats on your first PR to FDC3!

So we can track this PR correctly, could we open a related issue that includes the following:

  • Explanation of the use case/ problem solved by this PR
  • Documentation in both the Context and Intent parts of the Standard describing how to use it

I'm including the issue raised by @pauldyson CreateInteraction proposal as a reference if it helps #592

mistryvinay avatar Jul 04 '22 17:07 mistryvinay

Hi @kriswest @mistryvinay many thanks for the feedback. This is very helpful

I've just added another commit that should hopefully address the points you've raised. I have left a few questions in response to your feedback and would appreciate your thoughts.

@pauldyson and I are unable to attend the next two context and intents meetings, assuming the next one is two weeks today. I will review your feedback when I return on 22nd July.

Thanks

Milind.

milindchidrawar avatar Jul 06 '22 12:07 milindchidrawar

PR is based off of #747 and should not be merged until that has been, unless it is rebased on master first.

kriswest avatar Jul 21 '22 16:07 kriswest

Hi @kriswest @mistryvinay thanks for your patience with this.

I've merged master into this PR and have updated the remaining alphabetical sort issues. I noticed that transactionresult field 'context' was still of type string, which I have resolved.

Meanwhile in #747 I have approved and merged @mistryvinay's PR and have also resolved the alphabetical sort issues in there.

Hopefully this covers it. Let me know if there's any issues.

milindchidrawar avatar Aug 04 '22 16:08 milindchidrawar

@milindchidrawar @pauldyson I've dropped you a PR with some suggested tweaks (as discussed at today's meeting).

kriswest avatar Sep 01 '22 16:09 kriswest

Hi @kriswest I've made another round of changes and have also considered your feedback from #747 in this pull request as well.

i'll make another change asap to include a sample transactionResult for CreateInteraction along with the concept of an ID

Hopefully I've covered everything else.

milindchidrawar avatar Oct 18 '22 12:10 milindchidrawar