FDC3 icon indicating copy to clipboard operation
FDC3 copied to clipboard

Ensure types are generated when new contexts are merged into master branch

Open kriswest opened this issue 3 years ago • 1 comments

A PR (#747) is failing to build because it references another context type that was added in 2.0. In the PR the author has manually added the new context type with the reference. However, as types have not yet been generated for 2.0 (awaiting #745) the referenced type is missing.

Update the github actions to:

  • attempt to run type generation from context schemas on PRs (to check that they compile without error)
  • run type generation on merge to master as part of deployment, so that authors do NOT have to add the typescript manually, prior to deploying.

kriswest avatar Jun 09 '22 17:06 kriswest

Also consider releasing NPM module as a 'next' version with the newly generated types.

kriswest avatar Aug 04 '22 12:08 kriswest

Heavily related to:

  • https://github.com/finos/FDC3/issues/940

kriswest avatar May 17 '23 13:05 kriswest

superseded by #940

kriswest avatar Jul 18 '23 13:07 kriswest