react-window-size icon indicating copy to clipboard operation
react-window-size copied to clipboard

NPM code not here?

Open KyleAMathews opened this issue 5 years ago • 2 comments

I noticed a site I'm working on that uses this broke between 1.2.0 and 1.2.2. as you started checking document in the constructor which doesn't work for SSR.

Are you maintaining the package somewhere else now where I could raise an issue?

KyleAMathews avatar Aug 30 '18 19:08 KyleAMathews

apologies I forgot to push my local changes. They are there now

finnfiddle avatar Sep 06 '18 08:09 finnfiddle

The SSR issues aren't fixed, @finnfiddle did you forget to push your changes?

This plugin is unusable for frameworks like Gatsby and Next.js because it doesn't check whether the document exists. It looks like there's a PR to address that issue already (#9).

https://github.com/finnfiddle/react-window-size/blob/e70192bc2f67281b5154cc00a2b741116c6d0536/src/index.js#L11-L13

deammer avatar May 06 '19 22:05 deammer