Finn

Results 18 comments of Finn

> Do we know the exact version of boost that is added here? ROS is very picky about the exact version of boost. For noetic it must be 1.71 `rules_boost`...

I'd suggest that be a separate issue/PR as this PR copies exactly the same mechanism `rules_ros` currently uses, though instead of bringing it in via the `deps.bzl` as noted above:...

> Makes sense. > > Last small comment. How about paths such as in https://github.com/mvukov/rules_ros/blob/main/third_party/ros/roslaunch/deps.py.tpl#L1? Do they have to change with bzlmod? done

> Why is nobzlmod deleted? Maybe there are some folks around who would still like to use this in nobzlmode. The deletion of `--noenable_bzlmod` only directly affects building and testing...

I don't think there is anything left for me to resolve in this PR. As far as my testing is concerned, it works and is ready to merge.

> In my eyes, this is not a good enough reason to ditch workspace workflow, in particular if there are users of the workspace workflow who are depending on this...

I have a rough draft working with your project, I can aim to create a PR in the next couple of days if this interests you.

~This port is made a lot easier if we manage to port `rules_boost`: https://github.com/nelhage/rules_boost/issues/546~ Got this merged :)