finmath-lib icon indicating copy to clipboard operation
finmath-lib copied to clipboard

Merge fix in equity theta calculation.

Open agrotz opened this issue 4 years ago • 1 comments

What is this PR for?

Theta calculation in both analytic and PDE valuation for equity options with dividends did not reflect the part coming from the discount curve. This has been fixed now.

What type of PR is it?

Bug Fix

Todos

N/A

What is the related issue?

N/A

How should this be tested?

Unit tests have been adjusted to reflect corrected theta calculation

Screenshots

N/A

Questions:

Does the licenses files need update? NO

Are there breaking changes for older versions? NO

Does the change require additional documentation? NO

agrotz avatar Feb 13 '21 13:02 agrotz

I did not yet merge this, because the integration test failed. (Unit test). I will check it.

cfries avatar May 28 '22 22:05 cfries