fingerprintjs icon indicating copy to clipboard operation
fingerprintjs copied to clipboard

Create a demo using React to further help beginners understand how to integrate fingerprintjs

Open kanlancb opened this issue 3 years ago • 15 comments

Hello,

As the title says, although experienced people can easily integrate fingerprintjs with their react applications, I think it would be better if we add demo's showing how fingerprint can be integrated with other popular frameworks like react, angular and such.

I can immediately make one demo with react and give it a pull request, while doing changes in the readme to integrate the new demo after approval.

Let me know your thoughts

kanlancb avatar May 08 '22 05:05 kanlancb

Hey @kanlancb! Thank you for this suggestion and initiative! I think this is a really good idea and it might be a useful project.

As far as I know (pls, correct me if I'm wrong Sergey) we don't want to include framework-specific code/examples in the main repository. Nevertheless, if you could prepare a separate example repository with documentation and demo, I assume we would link it from our readme. What do you think @Finesse?

makma avatar May 10 '22 16:05 makma

🧏‍♂️

JsfasdF252 avatar May 12 '22 07:05 JsfasdF252

@makma Any further thoughts on this?

kanlancb avatar May 12 '22 11:05 kanlancb

@makma I think that it doesn't make much sense to put effort into making and maintaining separate repository(s). I'd put code examples into the docs directory and maybe create interactive demos using StackBlitz (like it's done with the code examples in the readme). StackBlitz is a nice solution for small demos, and I think that the React demo code will fit into a single screen.

Finesse avatar May 13 '22 01:05 Finesse

Hello everyone! I like the StackBlitz idea and the docs approach, what do you think @kanlancb?

makma avatar May 13 '22 07:05 makma

Sounds good, let me do it from my personal account @kanlanc

kanlancb avatar May 13 '22 13:05 kanlancb

@makma Is there any progress on this issue? We should either add examples to the docs, or close the issue.

Finesse avatar Jun 28 '22 05:06 Finesse

Hello, @Finesse @makma , very for the delay will try to make a PR by next week

kanlanc avatar Jun 29 '22 05:06 kanlanc

@kanlanc What are you going to do in the PR?

Finesse avatar Jun 29 '22 09:06 Finesse

@Finesse Add a react sandbox example and update the readme to reference the same

kanlanc avatar Jun 30 '22 08:06 kanlanc

@kanlanc Ok! If you use StackBlitz or a similar service, please share the full access to the sandbox with @makma.

Finesse avatar Jun 30 '22 09:06 Finesse

Hello @Finesse @makma ,

Here is the stackblitz url: https://react-ts-kxunqg.stackblitz.io

Please let me know if you want me to add or change something and meanwhile please let me know, the emails I will need to share the permissions to.

kanlanc avatar Jul 16 '22 11:07 kanlanc

I will update the readme once I receive the go signal for the demo

kanlanc avatar Jul 16 '22 11:07 kanlanc

Hey @kanlanc, The demo and code look good to me. For other folks, the original code can be found here: https://stackblitz.com/edit/react-ts-kxunqg?file=App.tsx. @kanlanc feel free to add a readme with your handle or some other kind of attribution if you want. Also, please include the MIT license to the stackblitz project. Once you are done, share the link with me on this thread, I'll fork it and then I will provide you with a link for the readme. Sounds good?

makma avatar Jul 20 '22 14:07 makma

@kanlanc Any progress on this?

Finesse avatar Aug 05 '22 11:08 Finesse

Yes, will do it this weekend, got caught up at work

kanlanc avatar Aug 13 '22 16:08 kanlanc

@makma Sorry for the delay, freshly moved to New york so got caught up in that, I have added a readme with the handle, updated the package.json with the MIT license, please do let me know if there is anything else is required

kanlanc avatar Sep 15 '22 22:09 kanlanc

I added a LICENSE file and proposed changes in https://github.com/fingerprintjs/fingerprintjs/pull/816

makma avatar Sep 18 '22 11:09 makma