fingerprintjs
fingerprintjs copied to clipboard
Create a demo using React to further help beginners understand how to integrate fingerprintjs
Hello,
As the title says, although experienced people can easily integrate fingerprintjs with their react applications, I think it would be better if we add demo's showing how fingerprint can be integrated with other popular frameworks like react, angular and such.
I can immediately make one demo with react and give it a pull request, while doing changes in the readme to integrate the new demo after approval.
Let me know your thoughts
Hey @kanlancb! Thank you for this suggestion and initiative! I think this is a really good idea and it might be a useful project.
As far as I know (pls, correct me if I'm wrong Sergey) we don't want to include framework-specific code/examples in the main repository. Nevertheless, if you could prepare a separate example repository with documentation and demo, I assume we would link it from our readme. What do you think @Finesse?
🧏♂️
@makma Any further thoughts on this?
@makma I think that it doesn't make much sense to put effort into making and maintaining separate repository(s). I'd put code examples into the docs directory and maybe create interactive demos using StackBlitz (like it's done with the code examples in the readme). StackBlitz is a nice solution for small demos, and I think that the React demo code will fit into a single screen.
Hello everyone! I like the StackBlitz idea and the docs approach, what do you think @kanlancb?
Sounds good, let me do it from my personal account @kanlanc
@makma Is there any progress on this issue? We should either add examples to the docs, or close the issue.
Hello, @Finesse @makma , very for the delay will try to make a PR by next week
@kanlanc What are you going to do in the PR?
@Finesse Add a react sandbox example and update the readme to reference the same
@kanlanc Ok! If you use StackBlitz or a similar service, please share the full access to the sandbox with @makma.
Hello @Finesse @makma ,
Here is the stackblitz url: https://react-ts-kxunqg.stackblitz.io
Please let me know if you want me to add or change something and meanwhile please let me know, the emails I will need to share the permissions to.
I will update the readme once I receive the go signal for the demo
Hey @kanlanc, The demo and code look good to me. For other folks, the original code can be found here: https://stackblitz.com/edit/react-ts-kxunqg?file=App.tsx. @kanlanc feel free to add a readme with your handle or some other kind of attribution if you want. Also, please include the MIT license to the stackblitz project. Once you are done, share the link with me on this thread, I'll fork it and then I will provide you with a link for the readme. Sounds good?
@kanlanc Any progress on this?
Yes, will do it this weekend, got caught up at work
@makma Sorry for the delay, freshly moved to New york so got caught up in that, I have added a readme with the handle, updated the package.json with the MIT license, please do let me know if there is anything else is required
I added a LICENSE file and proposed changes in https://github.com/fingerprintjs/fingerprintjs/pull/816