mssqlex
mssqlex copied to clipboard
findmypast-oss
Update to Ecto 3
Description
An early beta version of mssqlex for the mssql_ecto migration to Ecto 3.
Motivation and Context
The result of my efforts to try and update mssql_ecto to Ecto 3
How Has This Been Tested?
Updated the unit tests to use db_connection 2.0 and modified them until they passed. Additionally the integration testing described in this pull request to mssql_ecto.
Types of changes
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Breaking change (fix or feature that would cause existing functionality to change)
Checklist:
- [x] My code follows the code style of this project.
- [x] My change requires a change to the documentation.
- [x] I have updated the documentation accordingly.
- [ ] I have added tests to cover my changes.
- [x] All new and existing tests passed.
I will at least get the unit tests working for this one before we close this pull request. The failing tests are due to a change in how NaiveDateTime is handled in a recent commit. A job for next weekend.
Ah, it's types in general, not just NaiveDateTime. Anyway, next weekend's problem.
Hi, it's failing when joining multiple tables and using column and table aliases. @whossname, hope you can fix it !
Haha, yeh I was actually working on this today. Hopefully my fix works
On Fri, Sep 13, 2019, 11:45 PM Matías Reyes [email protected] wrote:
Hi, it's failing when joining multiple tables and using column and table aliases. @whossname https://github.com/whossname, hope you can fix it !
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/findmypast-oss/mssqlex/pull/24?email_source=notifications&email_token=ABXWLMKXAK5SSS33MNE3P2TQJOYQDA5CNFSM4IJEURLKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6VNJ2I#issuecomment-531289321, or mute the thread https://github.com/notifications/unsubscribe-auth/ABXWLMOKBGLE7HPIV2EOGQTQJOYQDANCNFSM4IJEURLA .
@matreyes the code from two commits ago should address that. It might fail if columns from different tables have the same name.
We are hoping to have a beta available soon. What is your time frame for needing this?
@matreyes I just added this test for the situation you are describing, and in my branch at least it is working fine. Could you please elaborate on what the issue is and if possible suggest a better test?
@jbachhardie this is ready for review. I think it should be basically ready to publish.
Thank you for all your hard work and apologies for not getting to this yet I'll book out some time to review/publish it next week.
I've been playing around a bit and it seems like the "No SQL-driver information available." triggers when you try to delete data and htere is nothing to delete. This may not be the only case where this error is triggered, but I think it is a bit of a clue as to why it is happening.
@whossname @jbachhardie Hey! Do you need some help? I have some time this month and it will be great to finish this PR and push it to hex :)
I would suggest that the way forward is to depreciate this repository in favour of TDS
https://github.com/livehelpnow/tds
@nikneroz this is way harder than it looks unless you have a deep understanding of both Ecto and Transact SQL. I wasn't up to the task needed way more time and effort than I had available. That TDS repo should work fine though.
I would suggest that the way forward is to depreciate this repository in favour of TDS
https://github.com/livehelpnow/tds
Ok, thank you!
@nikneroz this is way harder than it looks unless you have a deep understanding of both Ecto and Transact SQL. I wasn't up to the task needed way more time and effort than I had available. That TDS repo should work fine though.
I'll check the current state and will try to figure out what do we have at this moment.