Results 108 comments of Marius Grama

@vihangk1 pls also rebase on `trino/master` to address the code conflicts.

@vihangk1 here is a patch to solve the binding problem which was keeping you from removing the dependency towards `ThriftMetastoreConfig` ``` Subject: [PATCH] hive bindings --- Index: plugin/trino-hive/src/main/java/io/trino/plugin/hive/metastore/thrift/ThriftMetastoreModule.java IDEA additional...

Build is 🔴 ``` Error: Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.12.1:compile (default-compile) on project trino-hive: Compilation failure Error: /home/runner/work/trino/trino/plugin/trino-hive/src/main/java/io/trino/plugin/hive/metastore/thrift/ThriftMetastoreModule.java:[107,49] [UnnecessaryParentheses] These grouping parentheses are unnecessary; it is unlikely the code will...

> Could you confirm product test failure? https://github.com/trinodb/trino/actions/runs/7881376966/job/21505082153?pr=20371 This is related to an internal hickup in the Databricks account used for testing Trino OSS. Apparently someone removed (accidentaly) in the...

`ci/test (plugin/trino-kudu)` unrelated failure https://github.com/trinodb/trino/issues/20697

https://github.com/trinodb/trino/actions/runs/8622811102/job/23635002663?pr=18521

FYI there is also another PR tackling the AWS Glue library update https://github.com/trinodb/trino/pull/17866

I had a rather easy job, because I built dbt-trino on top of dbt-presto adapter. I just went over https://docs.getdbt.com/docs/contributing/building-a-new-adapter site. I think it would be a nice addition to...

> @findinpath can you please investigate the CI outcome? https://github.com/trinodb/trino/actions/runs/3495735811/jobs/5852837911 showcases that the content can't be deleted on `presto-ci-test` S3 bucket. ``` Error: io.trino.plugin.hive.s3.TestTrinoS3FileSystemAwsS3.testDeleteNonRecursivelyNonEmptyDeepPath Time elapsed: 0.403 s