Marius Grama

Relevant documentation: https://docs.getdbt.com/docs/building-a-dbt-project/building-models/configuring-incremental-models#what-if-the-columns-of-my-incremental-model-change

@bachng2017 thank you for the feedback. It is really nice to see that the new features come to use in the community. Regarding the 1st point, please do describe in...

From dbt slack https://getdbt.slack.com/archives/C2JRRQDTL/p1637588715264700?thread_ts=1637582164.264100&cid=C2JRRQDTL you may make use of dbt macros for adding dynamic functionality to the `config` element of your dbt model: ``` config(partitions = [parse_partition()], ...) ``` or...

@retrry exactly, `snapshot` will likely land very soon on `dbt-trino`.

Can you please describe in detail a reproduction scenario for this issue? Feel free to fill in some scripts for very small models that make this problem reproducible. Specifying the...

Please also squash the commits to one.

@osscm I see that `releaseTableLock()` operation throws a `TrinoException` when dealing with an `TException` (`NoSuchLockException` extends `TException`). @marton-bod the exception is supressed in the https://github.com/apache/iceberg/pull/987 , but the table still...

After handling https://github.com/trinodb/trino/issues/14104 , the logic throws now a `CommitStateUnknownException` when doing the `replaceTable` operation. https://github.com/trinodb/trino/blob/15dd728c6d2f865bc9ece9672a32df9314b7a4e7/plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/catalog/hms/HiveMetastoreTableOperations.java#L91-L96 So the operation which potentially can corrupt the table succeeded. Regarding the lock release...

This issue is rather critical because it renders the Iceberg table **corrupt**. Do note that this should be handled with a higher priority in order to have the fix available...

@pettyjamesm I have addressed your comment. As you mentioned offline there is definitely room for improvement in `io.trino.plugin.hive.s3.TrinoS3FileSystem#rename` . I would suggest addressing the refactoring of this method in a...