react-final-form icon indicating copy to clipboard operation
react-final-form copied to clipboard

feat: 🔄 use StrictOmit

Open Beraliv opened this issue 4 years ago • 3 comments
trafficstars

Hey 👋

I've seen that Omit usage was removed here – https://github.com/final-form/react-final-form/pull/589

I was interested whether you want to use builtin Omit from typescript or use StrictOmit from ts-essentials which also checks if the property is in the object (before removing it)

If you prefer Omit to not use ts-essentials, I will adapt the PR to be able to get rid of ts-essentials

Refers to https://github.com/final-form/react-final-form/issues/765

Beraliv avatar Oct 03 '21 12:10 Beraliv

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 1f5e706ccb95c5dd11225584323d3c8359c4e868:

Sandbox Source
React Final Form - Simple Example Configuration
React Final Form - Synchronous Record Level Validation Configuration
React Final Form - Synchronous Field Level Validation Configuration
React Final Form - Submission Errors Configuration
React Final Form - Subscriptions Example Configuration

codesandbox-ci[bot] avatar Oct 03 '21 12:10 codesandbox-ci[bot]

@Beraliv Please use the built-in typescript Omit as per the recommendation https://github.com/final-form/react-final-form/pull/589#issuecomment-521011710

gertdreyer avatar Jan 13 '23 14:01 gertdreyer

I'm happy to do it

Beraliv avatar Jan 13 '23 15:01 Beraliv