react-final-form-html5-validation icon indicating copy to clipboard operation
react-final-form-html5-validation copied to clipboard

React 17 compatibility

Open MoltenCoffee opened this issue 3 years ago • 2 comments

bug report/feature request

What is the current behavior?

React 17 is not listed as a peerDependency, causing NPM to throw "could not resolve dependency" when using React 17.

What is the expected behavior?

As I believe this package is pefectly able to work under React 17, peerDependencies should be updated:

{
  "react": "^15.3.0 || ^16.0.0-0 || ^17.0.0",
  "react-dom": "^15.3.0 || ^16.0.0-0 || 17.0.0",
}

What's your environment?

Final form: 4.20.1 React-final-form: 6.5.2 React-final-form-html5-validation: 1.1.0

Node 15.2.0 NPM 7.0.8

MoltenCoffee avatar Nov 17 '20 09:11 MoltenCoffee

Bump? I was about to use this thinking it would be great. But it doesn't support the current version of React... Happy to contribute something if needed.

sethreidnz avatar Mar 21 '21 02:03 sethreidnz

I'm already using it myself in React 17 without problems, I really think it's just a peerDependency issue (with NPM 7 handling those differently).

Installing with NPM flag ---legacy-peerd-deps fixes errors thrown by NPM, but we shouldn't have to do that. React-final-form seems to have been updated 3 days ago, so I have hope this will be fixed soon as well.

MoltenCoffee avatar Mar 23 '21 08:03 MoltenCoffee