roc icon indicating copy to clipboard operation
roc copied to clipboard

Fix binary decoders

Open jeremyrsmith opened this issue 8 years ago • 2 comments

I did this because many of the binary decoders were incorrect.

  • Remove existing binary decoder tests and replace with integration tests against postgres (To verify that they do actually decode the actual PG binary representation)
  • Update existing binary decoders for date/timestamp/time, string, and json
  • Add hstore decoder
  • Add numeric decoder

jeremyrsmith avatar Jun 27 '16 20:06 jeremyrsmith

Current coverage is 83.13%

Merging #72 into master will decrease coverage by 3.83%

@@             master        #72   diff @@
==========================================
  Files            18         18          
  Lines           760        836    +76   
  Methods         748        819    +71   
  Messages          0          0          
  Branches         12         17     +5   
==========================================
+ Hits            661        695    +34   
- Misses           99        141    +42   
  Partials          0          0          

Sunburst

Powered by Codecov. Last updated by 0161b7c...63088d4

codecov-io avatar Jun 27 '16 20:06 codecov-io

All of this looks great! I'm super excited to accept a PR for this :) . If you can delete those unit tests that aren't being called, I think this is ready to go.

penland365 avatar Jun 28 '16 02:06 penland365