finagle
Is finch dead?
No value judgement, I currently rely on it for a few projects and I'm wondering if I should just move on? I'd be happy to merge scala-steward pulls etc to keep it ticking over.
Yea I get the sentiment, and I'd get it if you wanted to move on. We definitely haven't been very active over the last year or so. Sergey and I had talked earlier this year about the next release. The only real thing remaining is to update the docs which was half done in #1231. I think we'll be in a much better spot for getting back to a more regular-ish releases once we've released that. For my part, I haven't had a ton of time in awhile, although I'm hoping to get freed up in the next couple months to work on it.
@sergeykolbasov Maybe it makes sense to post your doc redesign idea for 0.33.0 in an issue (happy to port it over if you don't have time) and see if any other folks can help. We might also consider bring on some more people. Happy to chat about that here or in the maintainers chat.
Not sure if other folks have thoughts here, but would be happy for more input.
Finch is definitly very handfull and pleasant to use, we're glad to have migrated on it. The only drawback we have met is with the dependencies updates, on which we would be glad to help maintain as well.
As it stands I'm not dying for features. I think it works well as a library, I think it's more just keeping up with deps shakes fist at jackson.I think a docs refresh would be grand. I have a PR for last year targetting one tiny part of the docs #1274 and it's that kind of thing (references to removed code) I think that makes the project look unmaintained. I think the overall quality of the project is great.
Well, it's gotten to the point where I can't update key dependencies (shapless / circe), adios amigos. Thanks for the ride :)
Can we just onboard new maintainers? I would be happy to help, even if it's just updating dependencies and cutting new releases.
Its clear to me that we (the maintainers) didn't do enough to push this forward, especially when this issue was first raised. I'm +1 to adding more people, even if only to do version bumps.
@sergeykolbasov @vkostyukov Thoughts on the above? I'd prefer to not just add people unilaterily.
@joroKr21 It sounds like you are interested. @tpetillot It sounds like you might have been interested at one point, is that still the case?
@joroKr21 It sounds like you are interested.
Yes, I'd be interested. I hope we can release by just publishing a tag - if not automating releases would be the single most important thing for me.
Sorry for the delay, I have invited both @joroKr21 and @tpetillot to the repo.
I hope we can release by just publishing a tag
So we do have an automated release process, however its not tag based. What we do to trigger the release process is push a commit like this, that removes the -SNAPSHOT part of the version and then CI kicks and handles the release.
So we do have an automated release process, however its not tag based. What we do to trigger the release process is push a commit like this, that removes the -SNAPSHOT part of the version and then CI kicks and handles the release.
Does it mean right after the release you need another commit to add -SNAPSHOT again?
@joroKr21 seems like CI add it back https://github.com/finagle/finch/commit/78b2f15f62dbaaa89529f4132d315d3f4f4b85c2
@joroKr21 if you're up to, we may discuss the takeover of the updates on https://gitter.im/finagle/finch
Started with https://github.com/finagle/finch/pull/1446 to allow IntelliJ proper indexing. Next updates will be: finagle, shapeless and circe on which I've not detected any breaking change.
CE3 is not a priority for us ATM, so I guess I'll update as much as possible dependencies under 0.32.2, then bring CE3 under 0.33.0 if you're ok with it?
Let me know if you wish keep an eye from distance, or if I should merge PR on my own (which I'll not until it has been stated).
Next updates will be: finagle, shapeless and circe on which I've not detected any breaking change.
There are a bunch of scala-steward PRs we can merge
@rpless 756cea1a61ae82418ba7c3413f05448d71dde402 release doesn't seems to be triggered, as it's not a Github Action I don't think I have any visibility neither other control on it... Any hint?
Uh I did not realize we were on github actions. Last I checked the we released via Travis CI. It looks like the github action does not invoke ./build/build.sh which is whats needed to release. That also requires some secrets that I don't think I have, I can't move those over to github actions. We might need to delete the github actions setup and go back to Travis CI.
It looks like @sergeykolbasov set github actions up. He probably has more insight.
I'm not sure of which github actions setup you're talking about (currently, on this repository, GA only handle tests). Indeed, it definitly look like everything is configure for Travis CI.
Hope we'll be able to release soon🙏
I think we may just need to revert this commit for now. I know most people tend to prefer Github Actions these days, but I'm not really sure whats involved in porting the release process to it.
@rpless not sure to understand what you mean. Is Travis CI still setup? Does it ignore finch repository because of the github actions folder? If removed, would the tests be triggered elsewhere?
Sorry if I was not clear. My guess is that the travis build is not happening due to the github actions folder being there. My guess is that removing it will allow the travis build process to happen. As far as I can tell travis is still configured and has access to the repo.
thank you for your clarifications, just tried and nothing seems to happend. I'm not familiar with travis, but while checking under https://app.travis-ci.com/github/finagle/finch I've a a danger alert at top indicating:
We are unable to start your build at this time. You exceeded the number of users allowed for your plan. Please review your plan details and follow the steps to resolution.
Last build was https://app.travis-ci.com/github/finagle/finch/builds/249090088 on https://github.com/finagle/finch/commit/117129bb2c7089250cb227842e5c05cf579e3ec7 (which seems to be way before github action test was added)
Well thats not great. It looks like travis ci did a migration last year and now it won't work for us. I think this means travis is a no go. It also looks like we lost our environment variables which is problem cause we had a secret env var in there that was the password to all the encrypted files. I'm gonna reach out to @vkostyukov to see if he has that. If he does that means we should be able to port the build to github actions.
Given that its looking like we'll need to rebuild this I'm open to suggestions on what CI we use.
I'm also familiar with github actions, so would be perfect for me. Hope secret is still in hand! 🙏
Also, does the release process include sonatype release? or does it require user releasing closed repository?
Ok so the good news is that Vladimir had the password. I've confirmed that it works and have uploaded it as a Github Actions Secret. Its name is ENCRYPTION_PASSWORD to keep inline with what the script calls it.
I'm not terribly familiar with Github actions, but it does seem like the best way forward. I think if we could get a Github Action that calls the current ./build/build.sh file that would probably be the fastest way forward. It will need some minor updates to stop referencing the Travis specific environment variables.
Also, does the release process include sonatype release? or does it require user releasing closed repository?
As I understand it, this is handled by CI. I don't have access to Sonatype but have released things to Maven Central before with our CI setup.
@rpless thank you so much for digging into this!
I'm also not super familiar with Github Actions but, from what I can tell, if they can run our script, the magic should happen on its own. Anything I can help with at the moment?
i updated the build script to help with this effort #1461
thank you for recovering the password @vkostyukov !
A few years later Finagle itself is unmaintained so that kinda decides it for Finch: https://github.com/twitter/finagle/issues/943