Benedikt Reinartz

Results 331 comments of Benedikt Reinartz

It's been a while, but let me answer/comment: > FYI On the Python C API, we started to stop adding *new* macros and sometimes even provide a new function with...

> So, I don't see the difference between accessing `ctx->h_None` and calling `ctx->ctx_GetNone()`. In both cases, you need to know the offset inside the struct. Yeah, this was confusing. What...

> `HPy_Dup` is just a small trampoline which jumps to `ctx->ctx_Dup`, which is a function pointer provided by the interpreter which contains the actual logic. The **offset** of `ctx_Dup` inside...

I'll see whether I can join next month, won't be able today. We use the .NET equivalent of `dlsym` to get the function pointers and manually hard-code the signatures. We...

All development is public. You can see here that the "simple" approach of adding new offsets (that I have indeed verified) fails. Debugging gave me additionally that it crashes in...

Aaah, got it, thanks @kunom! The issue is that, unlike all other members, the new `tp_watched` and `tp_versions_used` attributes are `char` and `uint16_t`. I'll update our `geninterop` script to pick...

On my local machine, the embedding tests also pass for 3.13. I'll have to spend some more time tomorrow to get the CI going, but I'm quite confident that I...

It is not failing tests, our CI is just a bit rusty. I ran a many combinations locally and will follow up in the next week to reactivate the excluded...

You are absolutely right! To help you with your repro (in case you hadn't seen this, yet), this code was introduced in #2383 to warn about badly formatted strings in...

I'll check again, I think when looking through this code before, I found another place in the same call were we take the GIL implicitly, so it wouldn't make things...