isaac-lua-api-vscode icon indicating copy to clipboard operation
isaac-lua-api-vscode copied to clipboard

Published 20 hours ago • verified publisher icon filloax

set preloadFileSize to 5000 in luarc

Open Zamiell opened this issue 3 years ago • 5 comments

the default is 500 but this is not enough to load isaacscript-common

Zamiell avatar Sep 03 '22 17:09 Zamiell

This issue is related to the VSCode extension and not this repository, so post it there, closing it here. I also do not currently have much time to work on the main extension logic with these bigger changes as I would have to learn how to do various things as I'm not yet very familiar with the VSCode API, but I will gladly accept PRs that implement them.

filloax avatar Sep 03 '22 21:09 filloax

It is also generally recommended to not have code files that big, what is the reason here?

filloax avatar Sep 08 '22 10:09 filloax

transpiling to multiple files would result in a worse UX, right?

Zamiell avatar Sep 08 '22 16:09 Zamiell

I understand then. Still, that would likely make it load luarooms files too, which would decrease performance in mods that use StageAPI, and performance for the extension (the Lua extension in general) has already been a complaint for developers that use this mod I'd rather not make a worse situation of.

This setting can be changed anyways; the extension only sets it if the current setting is lower than the target setting, so if you increase it it'll stay increased.

filloax avatar Sep 08 '22 19:09 filloax

I understand then. Still, that would likely make it load luarooms files too, which would decrease performance in mods that use StageAPI, and performance for the extension (the Lua extension in general) has already been a complaint for developers that use this mod I'd rather not make a worse situation of.

can we set sumneko to ignore anything in the luarooms/** glob?

doing that would sidestep the problem you describe

Zamiell avatar Sep 08 '22 20:09 Zamiell