PWAsForFirefox icon indicating copy to clipboard operation
PWAsForFirefox copied to clipboard

Full URL exceptions for `openOutOfScopeInDefaultBrowser`

Open pklapperich opened this issue 1 year ago • 5 comments

Problem Description

Two of the applications I use in PWAs are chat.google.com and meet.google.com. If I don't have "openOutOfScopeInDefaultBrowser" set, then links I click in meetings or in chat either open in a new tab or replace the chat/meet (not great to click a link in a meeting and then have to rejoin.) But I can't /always/ leave this setting enabled, because Google sends me back to the login page one every month or two. The login page is https://accounts.google.com.

It was actually a bit confusing and took me some time the first time I got logged out, as the PWA said "click login" and whenever I did that, the login page opened in my main browser (where I was already logged in)

Proposed Solution

Add a list of openOutOfScopeExceptions for the out of scope links. Then everything not in that list will open in the default browser, but anything on that list will open in the PWA. That way I could add https://accounts.google.com as an exception for both my Chat and Meet apps allowing me to re-login without the need to change settings in about:config every month.

pklapperich avatar Aug 10 '23 13:08 pklapperich

This sounds like "Domains always allowed to be opened in the app browser" (although it matches only domains and not full URLs).

filips123 avatar Aug 14 '23 18:08 filips123

Full URLs would be very useful in that list -- because if you have Google Apps with SSO, then your internal SSO platform will be a specific URL inside your domain.

aiyagari avatar Oct 04 '23 09:10 aiyagari

I may add this in the future. Another similar request is to have list of URLs that should not open in the app browser. I will check if I can add both of them, but I can't promise when, because I also need to rewrite quite a lot of things to make this (and other things) work more consistently.

filips123 avatar Oct 16 '23 19:10 filips123

I think this is the same issue with the MS Teams PWA. Links in the chat have target=_blank but if I click them, it just drops me from the call and replaces the PWA with some random webpage that somebody linked to. If I enable "Open out-of-scope URLs in a default browser (can break some web apps)" then the links in the chat work correctly, but when I open the PWA (after it's been closed for an hour or two) the login process will just open into the main browser and I can't even start the PWA without going back and UNchecking that option to let the login flow work.

It would be great if I could check that box, but also manually add some domain or wildcard that's additionally considered "in-scope". I tried adding a bunch of domains to "Domains always allowed to be opened in the app browser" but it did not allow the login process to work still, while having "Open out-of-scope URLs in a default browser (can break some web apps)" checked.

ryanrubleycoates avatar Nov 17 '23 06:11 ryanrubleycoates

I think this is the same issue with the MS Teams PWA. Links in the chat have target=_blank but if I click them, it just drops me from the call and replaces the PWA with some random webpage that somebody linked to. If I enable "Open out-of-scope URLs in a default browser (can break some web apps)" then the links in the chat work correctly, but when I open the PWA (after it's been closed for an hour or two) the login process will just open into the main browser and I can't even start the PWA without going back and UNchecking that option to let the login flow work.

It would be great if I could check that box, but also manually add some domain or wildcard that's additionally considered "in-scope". I tried adding a bunch of domains to "Domains always allowed to be opened in the app browser" but it did not allow the login process to work still, while having "Open out-of-scope URLs in a default browser (can break some web apps)" checked.

you can: image

image

image

snoweuph avatar Aug 01 '24 07:08 snoweuph