filips123
Windows installer does not detect existing install type (per-user/per-machine)
Description
Windows shortcuts to PWAs are not stable across reboots.
Steps to Reproduce
- Have Windows
- Pin a PWAFF window to the taskbar, or make a desktop shortcut
- Reboot your PC
- The shortcuts will not work anymore
Additional Information
Environment
- Operating system: Win 11
- System architecture: 64-bit
- Installation method: MSI
- PWAsForFirefox extension version: 2.3.0 (just auto-updated to 2.4.0; haven't rebooted with new native v yet)
- PWAsForFirefox native version: 2.3.0
- Firefox version: 108.0.2
Please check if there is anything in C:\Program Files\FirefoxPWA and %LOCALAPPDATA%\Programs\FirefoxPWA. Also, please check if PWAsForFirefox is still listed as installed in the Windows program list.
You can also try to (re)install the native program again.
Just installed the new version of the native program, 2.4.0.
%LOCALAPPDATA%\Programs\FirefoxPWA exists but is empty.[^1]
C:\Program Files\FirefoxPWA seems to contain the correct files (firefoxpwa.exe etc)
PWAsForFirefox is correctly listed in Apps > Installed apps (the Win 11 name for "Add or remove programs")
The new shortcut I created correctly points to "C:\Program Files\FirefoxPWA\firefoxpwa.exe" site launch 01GKJAKZD0C7G31S5NQ2G88MHM
Will update when I reboot
[^1]: Might have installed previous MSIs for one user only, and the last one for all users, hence the two locations.
(EDIT: To be clear, my shortcuts broke even before I did this)
Might have installed previous MSIs for one user only, and the last one for all users, hence the two locations
This happened to me (also Windows 11). I updated to 2.4.0 with the msi and chose to install for all users, forgetting I had previously installed for just myself.
After updating from 2.2.0 to 2.4.0, the extension kept saying it was still on 2.2.0. I checked under Windows Control Panel where it showed both versions installed. Uninstalling 2.2.0 caused my shortcuts to break.
To resolve the issue, I uninstalled 2.4.0 and uninstalled the extension from Firefox. Then I reinstalled the extension and the 2.4.0 msi, but this time just for myself instead of all users.
My previous shortcuts work again and I didn't lose any of my apps from the extension, so that was a nice touch.
I updated to 2.4.0 with the msi and chose to install for all users, forgetting I had previously installed for just myself.
This is probably what caused this problem. I'll check if I can make the installer remember how the package was previously installed, but I'm not sure if it's possible.
Will update when I reboot
Yep, the shortcuts do work now after a reboot. The new issue title seems accurate