PWAsForFirefox icon indicating copy to clipboard operation
PWAsForFirefox copied to clipboard

Add helper scripts for building from source

Open JJRcop opened this issue 3 years ago • 1 comments

Problem Description

Building from source requires hand-editing some files, which is slightly tedious, but only trivially so.

Proposed Solution

Add some helper scripts under native/ and extension/ in both windows batch and POSIX sh formats, (or node.js, cross platform) They could either simply take an argument which is the version to replace, maybe perform validation that it confirms to the proper version format, and edit the files themselves.

If you want to be fancy, they could look at the current git tag from git describe and use that (maybe filtering out the leading "v")

Additional Information

I am able to make these myself, but I have a weird head on my shoulders and will probably delay for a while until eventually getting around to it, sorry.

JJRcop avatar Aug 03 '22 18:08 JJRcop

I agree that would be useful. Parsing the Git tag would also be very nice. Something similar is already done inside GitHub Actions for publishing, so I can probably just copy and slightly adjust that to some reusable scripts.

For native/, it could be inside the existing Makefile.toml, as cargo-make can automatically transpile (basic) bash commands to Windows batch, or use cross-platform duckscript in case transpiling doesn't work. This would also be useful because then you could just run something like makers prepare and then already existing makers install to install the package (but they should be separate commands)

For extension/, Node.js script could be used.

filips123 avatar Aug 05 '22 17:08 filips123