filipeom

Results 75 comments of filipeom

> I'm not sure I get the link with the linked issue, could you explain? Because this `(I32.add base size)` would overflow depending on the `base` pointer (i.e., if I...

> Aren't we going to miss some heap overflow with this simplification ? I'm not quite sure we would, can you give an example? Either way, I can close this...

> For instance, shouldn't we check that base + offset < size ? `size` is just the size of the heap chunk starting in `base` and that is what we...

Last run of testcomp: ## Benchmark results (commit hash=18e6fc28) :octopus: Using: - Tool: `owi_w8_O3_sZ3_concolic` - Timeout: `30.` - Output dir: `results-testcomp-owi_w8_O3_sZ3_concolic-2024-08-11_11h29m49s/` Results: | Nothing | Reached | Timeout | Other...

> This looks good to me. Did you check if we're still returning empty models on TestComp with this? Seems like the reached results are ok. It is expected that...

> > some tests don't actually create symbolic variables (but only a few benchmarks do this) > > Oh really ? I did not know about that and I was...

> OK great! Should I merge this then? We can yes. `select_i32` is not branching, but this should not impact the the analysis to much, at most we will get...

I also made Marvin give us the memory statistics: ![image](https://github.com/user-attachments/assets/03085993-930b-4c0a-b7ba-a5bfd868d8ac) Btw, I know that you've told me you don't like that we're always iterating through the results list to accumulate...

On a side note, do you think that adding `wait4` to an existing Unix library might be more appropriate than explicitly including it here? I was thinking of [ocaml-rusage](https://github.com/CraigFe/ocaml-rusage) or,...

> > Btw, I know that you've told me you don't like that we're always iterating through the results list to accumulate the results we want to print/compare. Do you...