Vadim Filin

Results 12 comments of Vadim Filin

Vendoring does not hook C files.

@diegoholiveira so maintain it, please!

@achille-roussel any updates on this? I have same problem

Reading loop won't have time to get message because connection will be immediately closed due p.lastReceivedTime exceeding. Please reset p.lastReceivedTime. Guys, come on! It's obvious!

Off-top: what the idea of reconnecting for V2 client? Reconnecting logic doesn't do re-subscription. So basically it's useless.

It won't work. Since `lastReceivedTime` wasn't reset `elapsedSecond` will be always bigger than `ReconnectWaitSecond`. My WS connection may be idle for hours. Therefore client will start reconnect infinitely. if appropriate...

For example instead of: ``` type MarketClient struct { publicUrlBuilder *requestbuilder.PublicUrlBuilder } // Initializer func (p *MarketClient) Init(host string) *MarketClient { p.publicUrlBuilder = new(requestbuilder.PublicUrlBuilder).Init(host) return p } ``` Use pattern...

For WS you can use this; https://github.com/filinvadim/go-bittrex

@ttmc @vrde @kansi ?