filestack-js icon indicating copy to clipboard operation
filestack-js copied to clipboard

Published 20 hours ago • verified publisher icon filestack

fix(sentry): remove problematic Sentry integration

Open namoscato opened this issue 1 year ago • 7 comments

Resolves #467 Resolves #482

  • What kind of change does this PR introduce?

    Bug fix and arguably breaking change

  • What is the current behavior? (You can also link to an open issue here)

    The current Sentry integration:

    1. records unhelpful errors (see https://github.com/filestack/filestack-js/issues/467)
    2. is incompatible with Sentry's latest version (see https://github.com/filestack/filestack-js/issues/482) which will be a recurring problem (see https://github.com/filestack/filestack-js/issues/416)

  • What is the new behavior (if this is a feature change)?

    This removes the Sentry integration in favor of users implementing this at their application layer, which seems simpler and more appropriate.

namoscato avatar Aug 06 '22 14:08 namoscato

@sebastian-wec, @pcholuj – do you have any thoughts on this change? This is currently blocking our ability to upgrade to Sentry's latest major version.

namoscato avatar Sep 01 '22 13:09 namoscato

This seems to be causing us issues too when upgrading to the latest version of sentry.

BenGale avatar Nov 15 '22 11:11 BenGale

@johnkoehn Hey, I see this is approved. How do we go about getting this merged?

ryan-gray-db avatar Dec 27 '22 19:12 ryan-gray-db

No clue @ryan-gray-db, I just approved it for the heck of it. All the engineers at filestack left after the company was acquired. It is a dead product.

johnkoehn avatar Dec 27 '22 19:12 johnkoehn

No clue @ryan-gray-db, I just approved it for the heck of it. All the engineers at filestack left after the company was acquired. It is a dead product.

Haha, that's good to know... We had no idea. Thank you!

ryan-gray-db avatar Dec 27 '22 20:12 ryan-gray-db

@sethk4783, @Yaminim07, @prem-celestial, @hemanth-3, @RatGabi (with recent activity in this repository) – are you able to help get this change shipped?

@johnkoehn and I have been repeatedly requesting that this pull request be merged for nearly a year. Unfortunately, the delay in addressing this matter has significantly hindered our ability to upgrade Sentry to its latest version across our applications.

namoscato avatar Jul 02 '23 18:07 namoscato

@namoscato I have tried to use your branch in the package.json, but it was throwing some errors, so tried to create my own fork and make it work. in case anybody needs - "filestack-js": "uplisting/filestack-js#chore/remove-sentry", works for me. link - https://github.com/uplisting/filestack-js/tree/chore/remove-sentry

artemgurzhii avatar May 15 '24 10:05 artemgurzhii