Files icon indicating copy to clipboard operation
Files copied to clipboard

Published 20 hours ago • verified publisher icon files-community

Feature: Remove FullTrust handlers

Open hez2010 opened this issue 3 years ago • 5 comments

We are migrating to WindowsAppSDK, thus there's no longer need for fulltrust process for interop. This will bring performance improvements since the overhead of (de)serialization and IPC can be avoided.

While removing handlers, note that we no longer need (de)serialization, so we should also remove all serialization code and use the underlying data directly. For example, base64-byte[].

Using this issue for tracking work-items of fulltrust handlers removal.

Requirements

  • remove these handlers
  • [x] ApplicationLaunchHandler
  • [x] ContextMenuHandler
  • [x] DesktopWallpaperHandler
  • [x] DriveHandler (assigned to @lukeblevins)
  • [ ] FileOperationsHandler
  • [ ] FileTagsHandler
  • [ ] IMessageHandler
  • [x] InstallOperationsHandler
  • [ ] LibrariesHandler
  • [ ] NetworkDrivesHandler
  • [x] QuickLookHandler
  • [ ] RecentItemsHandler
    • [ ] Watchers
    • [x] Others
  • [ ] RecycleBinHandler
    • [ ] Watchers
    • [x] Others
  • [ ] Win32MessageHandler
    • [ ] Watchers
    • [x] Others

hez2010 avatar Aug 30 '22 14:08 hez2010

@hez2010 I can take care of removing RecentItemsHandler once #9857 is merged because we'd want to have baked in support for a number of service implementations capable of listing/aggregating recent items from a multitude of sources down the road.

@yaichenbaum FYI

lukeblevins avatar Aug 30 '22 15:08 lukeblevins

@lukeblevins I'm wondering if @jiejasonliu might want to do the RecentItemsHandler since they were just working on this feature a couple months ago.

yaira2 avatar Aug 30 '22 16:08 yaira2

@yaichenbaum @jiejasonliu Please let me know.

lukeblevins avatar Aug 30 '22 17:08 lukeblevins

@lukeblevins @yaichenbaum I'm probably not going to be able to get to this anytime soon due to school. If you can get around doing this in the next month or so, I encourage it.

I can offer to be a primary/secondary reviewer to any pull requests related to it and also feel free to DM me of any questions, I'm on the Files discord server (Jason#9955).

jiejasonliu avatar Aug 30 '22 18:08 jiejasonliu

I'm almost done with the DriveHandler, so that one shouldn't be assigned to anyone else. @yaichenbaum

lukeblevins avatar Sep 08 '22 19:09 lukeblevins

@yaichenbaum This can probably be pinned again.

I am working on the RecycleBin handler/watcher so that one can be assigned to me.

lukeblevins avatar Oct 20 '22 21:10 lukeblevins

I can take a look at removing LibrariesHandler, probably not NetworkDrivesHandler because I don't have a network drive to test on.

itsWindows11 avatar Oct 21 '22 08:10 itsWindows11

Love the enthusiasm!

@itsWindows11 I believe there are ways to create virtual network drives.

Fyi @gave92

yaira2 avatar Oct 21 '22 15:10 yaira2

You can go to file explorer > right click a drive > go to properties > sharing > advance sharing > share this folder > ok. Then it will show up in the network section under your computer name. Which you can map to a drive letter

Josh65-2201 avatar Oct 21 '22 17:10 Josh65-2201

Love the enthusiasm!

@itsWindows11 I believe there are ways to create virtual network drives.

Fyi @gave92

What I usually do is creating a shared folder on my PC and then map it to a network drive with path \\localhost\myFolder

gave92 avatar Oct 21 '22 17:10 gave92

@yaichenbaum Can this be updated and assigned to @itsWindows11 and me?

lukeblevins avatar Oct 25 '22 04:10 lukeblevins

@itsWindows11 Just a fyi: It may be easier to rebase your branch based on #10283 once done testing. You can also open a PR to my PR branch and I'll absorb those changes you've done during review.

lukeblevins avatar Oct 25 '22 04:10 lukeblevins

Thanks to work submitted from @itsWindows11 and others, #10283 is now ready for extensive testing and review.

lukeblevins avatar Oct 26 '22 19:10 lukeblevins