Files icon indicating copy to clipboard operation
Files copied to clipboard

Focus on new folder by default when using ctrl + shift + n

Open jameslashmar opened this issue 3 years ago • 1 comments

What's the Problem?

Long winded UX for creating new folders

Solution/Idea

A section in preferences to set a folder as the new item type when using ctrl+shift+n. Creating a lot of folders is very cumbersome.

Additionally, when executing the shortcut, the new item type has folder highlighted as default, so hitting enter would then create the folder, or being able to shift up and down the list using the arrow keys and confirm the new selection using enter to execute would be ideal.

Alternatives

n/a

Priorities

Capability Priority
This proposal will allow developers to accomplish W Must
This proposal will allow end users to accomplish X Should
This proposal will allow developers to accomplish Y Could
This proposal will allow end users to accomplish Z Won't

Files Version

2.3.3.0

Windows Version

Win 11 22H2 22622.436

Comments

No response

jameslashmar avatar Jul 26 '22 12:07 jameslashmar

image

batmandarin avatar Jul 29 '22 10:07 batmandarin

Hi there, I think I found a solution to the problem, by adding an option on PreferenceSettingService and changing both ModernShellPage and ColumnShellPage to check if the option is enabled and redirect the shortcut "Ctrl + Shift + N" directly to CreateFileFromDialogResultType from UIFilesystemHelpers class, for the other part I've managed to focus the first item of AddItem ListView to be focused so it should be possible to travel the List via arrow keys.

The only problem I found so far is adding the Setting/Preference text to all the Resources.resw files, and if possible I would like to know what steps to follow or if it's not necessary on my part to complete that part.

Thanks on advance

@yaichenbaum

z3r0tru5tk4l1 avatar Aug 15 '22 20:08 z3r0tru5tk4l1

@z3r0tru5tk4l1 we shouldn't need a setting for this as it should be the default behavior 🙂 For the future, when adding a new string, adding the string to the en-us resource file is enough, the other strings are generated on our end.

yaira2 avatar Aug 15 '22 20:08 yaira2

@yaichenbaum Thanks for the quick answer, final question on how to continue, should I revert the changes made to the Setting/Preference and both ShellTypes as well as the Resource.resw change I made in the en-us folder? And only leave the autofocus on the firs item of the AddItem ListView or do I just create a PR for the changes made?

Thanks in advanced

z3r0tru5tk4l1 avatar Aug 15 '22 20:08 z3r0tru5tk4l1

should I revert the changes made to the Setting/Preference and both ShellTypes as well as the Resource.resw change I made in the en-us folder? And only leave the autofocus on the firs item of the AddItem ListView

That would be ideal 👍

yaira2 avatar Aug 15 '22 22:08 yaira2